linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: atomisp: restore missing 'return' statement
@ 2021-08-02 14:38 Arnd Bergmann
  2021-08-02 15:36 ` Sakari Ailus
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Arnd Bergmann @ 2021-08-02 14:38 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Greg Kroah-Hartman, Pavel Skripkin
  Cc: Arnd Bergmann, Sakari Ailus, linux-media, linux-staging, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

The input_system_configure_channel_sensor() function lost its final
return code in a previous patch:

drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]

Restore what was there originally.

Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 .../media/atomisp/pci/hive_isp_css_common/host/input_system.c   | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
index 8e085dda0c18..712e01c37870 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
@@ -1646,6 +1646,8 @@ static input_system_err_t input_system_configure_channel_sensor(
 	default:
 		return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
 	}
+
+	return INPUT_SYSTEM_ERR_NO_ERROR;
 }
 
 // Test flags and set structure.
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] media: atomisp: restore missing 'return' statement
  2021-08-02 14:38 [PATCH] media: atomisp: restore missing 'return' statement Arnd Bergmann
@ 2021-08-02 15:36 ` Sakari Ailus
  2021-08-13 16:38 ` Kees Cook
  2021-09-24 11:31 ` Praveen Kumar
  2 siblings, 0 replies; 9+ messages in thread
From: Sakari Ailus @ 2021-08-02 15:36 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, Pavel Skripkin,
	Arnd Bergmann, linux-media, linux-staging, linux-kernel

On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The input_system_configure_channel_sensor() function lost its final
> return code in a previous patch:
> 
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> 
> Restore what was there originally.
> 
> Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks!

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] media: atomisp: restore missing 'return' statement
  2021-08-02 14:38 [PATCH] media: atomisp: restore missing 'return' statement Arnd Bergmann
  2021-08-02 15:36 ` Sakari Ailus
@ 2021-08-13 16:38 ` Kees Cook
  2021-08-19 17:24   ` Andy Shevchenko
  2021-09-24 11:31 ` Praveen Kumar
  2 siblings, 1 reply; 9+ messages in thread
From: Kees Cook @ 2021-08-13 16:38 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, Pavel Skripkin,
	Arnd Bergmann, Sakari Ailus, linux-media, linux-staging,
	linux-kernel

On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The input_system_configure_channel_sensor() function lost its final
> return code in a previous patch:
> 
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> 
> Restore what was there originally.
> 
> Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I hit this too. Thanks!

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  .../media/atomisp/pci/hive_isp_css_common/host/input_system.c   | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8e085dda0c18..712e01c37870 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -1646,6 +1646,8 @@ static input_system_err_t input_system_configure_channel_sensor(
>  	default:
>  		return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
>  	}
> +
> +	return INPUT_SYSTEM_ERR_NO_ERROR;
>  }
>  
>  // Test flags and set structure.
> -- 
> 2.29.2
> 

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] media: atomisp: restore missing 'return' statement
  2021-08-13 16:38 ` Kees Cook
@ 2021-08-19 17:24   ` Andy Shevchenko
  2021-08-19 19:22     ` Pavel Skripkin
  2021-08-21  5:53     ` Kees Cook
  0 siblings, 2 replies; 9+ messages in thread
From: Andy Shevchenko @ 2021-08-19 17:24 UTC (permalink / raw)
  To: Kees Cook
  Cc: Arnd Bergmann, Mauro Carvalho Chehab, Greg Kroah-Hartman,
	Pavel Skripkin, Arnd Bergmann, Sakari Ailus, linux-media,
	linux-staging, linux-kernel

On Fri, Aug 13, 2021 at 7:39 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The input_system_configure_channel_sensor() function lost its final
> > return code in a previous patch:
> >
> > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
> > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> >
> > Restore what was there originally.
> >
> > Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I hit this too. Thanks!
>
> Reviewed-by: Kees Cook <keescook@chromium.org>

Me too,
Tested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Pavel, how have you tested it?

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] media: atomisp: restore missing 'return' statement
  2021-08-19 17:24   ` Andy Shevchenko
@ 2021-08-19 19:22     ` Pavel Skripkin
  2021-08-21  5:53     ` Kees Cook
  1 sibling, 0 replies; 9+ messages in thread
From: Pavel Skripkin @ 2021-08-19 19:22 UTC (permalink / raw)
  To: Andy Shevchenko, Kees Cook
  Cc: Arnd Bergmann, Mauro Carvalho Chehab, Greg Kroah-Hartman,
	Arnd Bergmann, Sakari Ailus, linux-media, linux-staging,
	linux-kernel

On 8/19/21 8:24 PM, Andy Shevchenko wrote:
> On Fri, Aug 13, 2021 at 7:39 PM Kees Cook <keescook@chromium.org> wrote:
>>
>> On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote:
>> > From: Arnd Bergmann <arnd@arndb.de>
>> >
>> > The input_system_configure_channel_sensor() function lost its final
>> > return code in a previous patch:
>> >
>> > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
>> > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
>> >
>> > Restore what was there originally.
>> >
>> > Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> I hit this too. Thanks!
>>
>> Reviewed-by: Kees Cook <keescook@chromium.org>
> 
> Me too,
> Tested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> Pavel, how have you tested it?
> 

To he honest, I didn't test it at all. It was part of application 
processes to LFX mentoship. I really don't like style changes. Anyway, I 
have to do it to pass the task, so, yeah, I messed up with this one ;(

Also, I didn't notice when patch was applied, because I was like 2 month 
after v3 posted. I am so sorry for this situation. Nowadays I always 
test my patches.

I was young and foolish :)


With regards,
Pavel Skripkin

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] media: atomisp: restore missing 'return' statement
  2021-08-19 17:24   ` Andy Shevchenko
  2021-08-19 19:22     ` Pavel Skripkin
@ 2021-08-21  5:53     ` Kees Cook
  2021-08-21  6:36       ` Mauro Carvalho Chehab
  1 sibling, 1 reply; 9+ messages in thread
From: Kees Cook @ 2021-08-21  5:53 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Greg Kroah-Hartman
  Cc: Arnd Bergmann, Andy Shevchenko, Pavel Skripkin, Arnd Bergmann,
	Sakari Ailus, linux-media, linux-staging, linux-kernel

On Thu, Aug 19, 2021 at 08:24:11PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 13, 2021 at 7:39 PM Kees Cook <keescook@chromium.org> wrote:
> >
> > On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > The input_system_configure_channel_sensor() function lost its final
> > > return code in a previous patch:
> > >
> > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
> > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> > >
> > > Restore what was there originally.
> > >
> > > Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > I hit this too. Thanks!
> >
> > Reviewed-by: Kees Cook <keescook@chromium.org>
> 
> Me too,
> Tested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Mauro, are you able to get this into your tree, please? Or Greg? It's in
staging. :) This is breaking the build.

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] media: atomisp: restore missing 'return' statement
  2021-08-21  5:53     ` Kees Cook
@ 2021-08-21  6:36       ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 9+ messages in thread
From: Mauro Carvalho Chehab @ 2021-08-21  6:36 UTC (permalink / raw)
  To: Kees Cook
  Cc: Greg Kroah-Hartman, Arnd Bergmann, Andy Shevchenko,
	Pavel Skripkin, Arnd Bergmann, Sakari Ailus, linux-media,
	linux-staging, linux-kernel

Em Fri, 20 Aug 2021 22:53:37 -0700
Kees Cook <keescook@chromium.org> escreveu:

> On Thu, Aug 19, 2021 at 08:24:11PM +0300, Andy Shevchenko wrote:
> > On Fri, Aug 13, 2021 at 7:39 PM Kees Cook <keescook@chromium.org> wrote:  
> > >
> > > On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote:  
> > > > From: Arnd Bergmann <arnd@arndb.de>
> > > >
> > > > The input_system_configure_channel_sensor() function lost its final
> > > > return code in a previous patch:
> > > >
> > > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
> > > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> > > >
> > > > Restore what was there originally.
> > > >
> > > > Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>  
> > >
> > > I hit this too. Thanks!
> > >
> > > Reviewed-by: Kees Cook <keescook@chromium.org>  
> > 
> > Me too,
> > Tested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>  
> 
> Mauro, are you able to get this into your tree, please? Or Greg? It's in
> staging. :) This is breaking the build.

Didn't notice it was breaking the build for you.

Patch applied, thanks!

Thanks,
Mauro

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] media: atomisp: restore missing 'return' statement
  2021-08-02 14:38 [PATCH] media: atomisp: restore missing 'return' statement Arnd Bergmann
  2021-08-02 15:36 ` Sakari Ailus
  2021-08-13 16:38 ` Kees Cook
@ 2021-09-24 11:31 ` Praveen Kumar
  2021-09-24 11:42   ` Praveen Kumar
  2 siblings, 1 reply; 9+ messages in thread
From: Praveen Kumar @ 2021-09-24 11:31 UTC (permalink / raw)
  To: Arnd Bergmann, Mauro Carvalho Chehab, Greg Kroah-Hartman, Pavel Skripkin
  Cc: Arnd Bergmann, Sakari Ailus, linux-media, linux-staging, linux-kernel

On 02-08-2021 20:08, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The input_system_configure_channel_sensor() function lost its final
> return code in a previous patch:
> 
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> 
> Restore what was there originally.
> 
> Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  .../media/atomisp/pci/hive_isp_css_common/host/input_system.c   | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8e085dda0c18..712e01c37870 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -1646,6 +1646,8 @@ static input_system_err_t input_system_configure_channel_sensor(
>  	default:
>  		return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
>  	}
> +
> +	return INPUT_SYSTEM_ERR_NO_ERROR;

I would recommend to return "status" instead of INPUT_SYSTEM_ERR_NO_ERROR,
this will take care of sending correct return code, we encounter in different case statements.
Something like below would be better. Thanks.

-               return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
+               status = INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
        }
+       return status;

Regards,

~Praveen.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] media: atomisp: restore missing 'return' statement
  2021-09-24 11:31 ` Praveen Kumar
@ 2021-09-24 11:42   ` Praveen Kumar
  0 siblings, 0 replies; 9+ messages in thread
From: Praveen Kumar @ 2021-09-24 11:42 UTC (permalink / raw)
  To: Arnd Bergmann, Mauro Carvalho Chehab, Greg Kroah-Hartman, Pavel Skripkin
  Cc: Arnd Bergmann, Sakari Ailus, linux-media, linux-staging, linux-kernel

On 24-09-2021 17:01, Praveen Kumar wrote:
> On 02-08-2021 20:08, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The input_system_configure_channel_sensor() function lost its final
>> return code in a previous patch:
>>
>> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
>> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
>>
>> Restore what was there originally.
>>
>> Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  .../media/atomisp/pci/hive_isp_css_common/host/input_system.c   | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
>> index 8e085dda0c18..712e01c37870 100644
>> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
>> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
>> @@ -1646,6 +1646,8 @@ static input_system_err_t input_system_configure_channel_sensor(
>>  	default:
>>  		return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
>>  	}
>> +
>> +	return INPUT_SYSTEM_ERR_NO_ERROR;
> 
> I would recommend to return "status" instead of INPUT_SYSTEM_ERR_NO_ERROR,
> this will take care of sending correct return code, we encounter in different case statements.
> Something like below would be better. Thanks.
> 
> -               return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
> +               status = INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
>         }
> +       return status;

Please ignore this comment. My bad, we don't reach anytime here during failure.

Regards,

~Praveen.


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-09-24 11:43 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 14:38 [PATCH] media: atomisp: restore missing 'return' statement Arnd Bergmann
2021-08-02 15:36 ` Sakari Ailus
2021-08-13 16:38 ` Kees Cook
2021-08-19 17:24   ` Andy Shevchenko
2021-08-19 19:22     ` Pavel Skripkin
2021-08-21  5:53     ` Kees Cook
2021-08-21  6:36       ` Mauro Carvalho Chehab
2021-09-24 11:31 ` Praveen Kumar
2021-09-24 11:42   ` Praveen Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).