From: cgel.zte@gmail.com
To: linux-kernel@vger.kernel.org
Cc: xu.xin16@zte.com.cn, Zeal Robot <zealci@zte.com.cn>
Subject: [PATCH linux-next] dio: add iounmap when ioremap() is called.
Date: Sat, 14 Aug 2021 02:37:18 -0700 [thread overview]
Message-ID: <20210814093718.105825-1-xu.xin16@zte.com.cn> (raw)
From: xu_xin <xu.xin16@zte.com.cn>
In __init dio_ini(void), when kzalloc() fails, we add the operation of
iounmap because ioremap is probably called in line 210.:
Reported-by: Zeal Robot<zealci@zte.com.cn>
Signed-off-by: xu_xin <xu.xin16@zte.com.cn>
---
drivers/dio/dio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index b2ff5ff84b80..21bdb16dc2f3 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -218,8 +218,8 @@ static int __init dio_init(void)
/* Found a board, allocate it an entry in the list */
dev = kzalloc(sizeof(struct dio_dev), GFP_KERNEL);
- if (!dev){
- if(scode >= DIOII_SCBASE)
+ if (!dev) {
+ if (scode >= DIOII_SCBASE)
iounmap(va);
return 0;
}
--
2.25.1
reply other threads:[~2021-08-14 9:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210814093718.105825-1-xu.xin16@zte.com.cn \
--to=cgel.zte@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xu.xin16@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).