From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCCFDC4320A for ; Sun, 15 Aug 2021 16:01:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1AAD61222 for ; Sun, 15 Aug 2021 16:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238408AbhHOQCT (ORCPT ); Sun, 15 Aug 2021 12:02:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:58726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbhHOQCR (ORCPT ); Sun, 15 Aug 2021 12:02:17 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C686761221; Sun, 15 Aug 2021 16:01:39 +0000 (UTC) Date: Sun, 15 Aug 2021 17:04:37 +0100 From: Jonathan Cameron To: "Lad, Prabhakar" Cc: Geert Uytterhoeven , Lad Prabhakar , Rob Herring , Lars-Peter Clausen , Magnus Damm , Philipp Zabel , Alexandru Ardelean , linux-iio , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , LKML , Biju Das Subject: Re: [PATCH v4 0/3] Renesas RZ/G2L ADC driver support Message-ID: <20210815170437.32be4ac1@jic23-huawei> In-Reply-To: References: <20210804202118.25745-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210808180143.6b3dc882@jic23-huawei> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Aug 2021 14:04:33 +0100 "Lad, Prabhakar" wrote: > Hi Jonathan, > > On Sun, Aug 8, 2021 at 5:58 PM Jonathan Cameron wrote: > > > > On Wed, 4 Aug 2021 21:21:15 +0100 > > Lad Prabhakar wrote: > > > > > Hi All, > > > > > > This patch series adds ADC support for Renesas RZ/G2L family. > > > > > > Patches apply on top of v5.14-rc2. > > Hi Lad, I'm fine with this, but need to pull my tree forwards > > to include the header that is only in rc2. > > > > I'll probably do that later in the week then pick up patches 1 and 2. > > > Thanks. > > Geert could you please pick patch 3/3. 1 and 2 now applied to the togreg branch of iio.git and pushed out as testing to see if 0-day can break them. Thanks, Jonathan > > Cheers, > Prabhakar > > > Thanks, > > > > Jonathan > > > > > > Cheers, > > > Prabhakar > > > > > > Changes for v4: > > > * Fixed registering action to assert resets on failure/remove > > > as reported by Philip. > > > * Fixed review comments suggested by Jonathan. > > > * Included RB tag from Rob for patch 1/3 > > > * Note DTS patch applies on top of https://git.kernel.org/pub/scm/ > > > linux/kernel/git/geert/renesas-devel.git/log/ > > > ?h=renesas-arm-dt-for-v5.15 > > > > > > Changes for v3 (as requested by Jonathan): > > > * Made use of FIELD_PREP() > > > * Renamed _CLEAR to _MASK and inverted inline as required > > > * Moved |= pair's on same lines > > > * Made use of sysfs_emit() while reading the labels > > > * Used for_each_bit_set() in rzg2l_adc_isr() > > > * Renamed rzg2l_adc_parse_of() -> rzg2l_adc_parse_properties() > > > * Used devm_add_action_or_reset() for asserting the reset signals and > > > disabling pm_runtime and eventually removing remove() callback > > > * Added comments in isr handler for channel select interrupt > > > * Moved enabling/disabling of pclk during hw init in rzg2l_adc_hw_init() > > > * Dropped clock patch 3/4 (https://lore.kernel.org/patchwork/patch/1462152/) > > > from previous series as its queued up in renesas-clk-for-v5.15 > > > > > > Changes for v2: > > > * Update binding doc, dropped gpios/renesas-rzg2l,adc-trigger-mode > > > properties included channel property to represent each wired channel. > > > * Fixed review comments pointed by Alexandru, implemented pm runtime > > > support, dropped mlock usage > > > * Fixed review comments pointed by Jonathan, renamed the macros, > > > simplified the code. > > > * Included clock and DT patches > > > > > > v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/ > > > 20210629220328.13366-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > > > > > Lad Prabhakar (3): > > > dt-bindings: iio: adc: Add binding documentation for Renesas RZ/G2L > > > A/D converter > > > iio: adc: Add driver for Renesas RZ/G2L A/D converter > > > arm64: dts: renesas: r9a07g044: Add ADC node > > > > > > .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 134 ++++ > > > MAINTAINERS | 8 + > > > arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 42 ++ > > > drivers/iio/adc/Kconfig | 10 + > > > drivers/iio/adc/Makefile | 1 + > > > drivers/iio/adc/rzg2l_adc.c | 600 ++++++++++++++++++ > > > 6 files changed, 795 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > > > create mode 100644 drivers/iio/adc/rzg2l_adc.c > > > > >