From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de,
a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com,
gwendal@chromium.org, alexandre.belloni@bootlin.com,
david@lechnology.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com,
patrick.havelange@essensium.com, fabrice.gasnier@st.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v15 09/13] counter: Implement signalZ_action_component_id sysfs attribute
Date: Sun, 15 Aug 2021 17:57:56 +0100 [thread overview]
Message-ID: <20210815175756.5e627c3d@jic23-huawei> (raw)
In-Reply-To: <d72159ab7ebfe607d86c0ab472979e8eca6f16a0.1628511445.git.vilhelm.gray@gmail.com>
On Mon, 9 Aug 2021 21:37:34 +0900
William Breathitt Gray <vilhelm.gray@gmail.com> wrote:
> The Generic Counter chrdev interface expects users to supply component
> IDs in order to select Synapses for requests. In order for users to know
> what component ID belongs to which Synapse this information must be
> exposed. The signalZ_action_component_id attribute provides a way for
> users to discover what component ID belongs to the respective Synapse.
>
> Cc: Gwendal Grignou <gwendal@chromium.org>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: David Lechner <david@lechnology.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
> Contact: linux-iio@vger.kernel.org
> diff --git a/drivers/counter/counter-sysfs.c b/drivers/counter/counter-sysfs.c
> index dbb507c9da11..11bef9f8190f 100644
> --- a/drivers/counter/counter-sysfs.c
> +++ b/drivers/counter/counter-sysfs.c
> @@ -393,7 +393,6 @@ static int counter_avail_attr_create(struct device *const dev,
> struct counter_attribute *counter_attr;
> struct device_attribute *dev_attr;
>
> - /* Allocate Counter attribute */
Trivial, but this is an unrelated change and shouldn't be in this patch (it's just noise).
> counter_attr = devm_kzalloc(dev, sizeof(*counter_attr), GFP_KERNEL);
> if (!counter_attr)
> return -ENOMEM;
> @@ -535,6 +534,46 @@ static int counter_name_attr_create(struct device *const dev,
> return 0;
> }
>
next prev parent reply other threads:[~2021-08-15 16:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 12:37 [PATCH v15 00/13] Introduce the Counter character device interface William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 01/13] counter: 104-quad-8: Describe member 'lock' in 'quad8' William Breathitt Gray
2021-08-09 19:26 ` Jonathan Cameron
2021-08-09 12:37 ` [PATCH v15 02/13] counter: Internalize sysfs interface code William Breathitt Gray
2021-08-15 16:31 ` Jonathan Cameron
2021-08-09 12:37 ` [PATCH v15 03/13] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 04/13] docs: counter: Update " William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 05/13] counter: Move counter enums to uapi header William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 06/13] counter: Add character device interface William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 07/13] docs: counter: Document " William Breathitt Gray
2021-08-15 16:51 ` Jonathan Cameron
2021-08-21 10:52 ` William Breathitt Gray
2021-08-22 2:03 ` Akira Yokosawa
2021-08-09 12:37 ` [PATCH v15 08/13] tools/counter: Create Counter tools William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 09/13] counter: Implement signalZ_action_component_id sysfs attribute William Breathitt Gray
2021-08-15 16:57 ` Jonathan Cameron [this message]
2021-08-09 12:37 ` [PATCH v15 10/13] counter: Implement *_component_id sysfs attributes William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 11/13] counter: Implement events_queue_size sysfs attribute William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 12/13] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 13/13] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray
2021-08-09 19:34 ` [PATCH v15 00/13] Introduce the Counter character device interface Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210815175756.5e627c3d@jic23-huawei \
--to=jic23@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=dan.carpenter@oracle.com \
--cc=david@lechnology.com \
--cc=fabrice.gasnier@st.com \
--cc=gwendal@chromium.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=kamel.bouhara@bootlin.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=patrick.havelange@essensium.com \
--cc=syednwaris@gmail.com \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).