From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D22CC4338F for ; Mon, 16 Aug 2021 12:17:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7A1F63249 for ; Mon, 16 Aug 2021 12:17:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234536AbhHPMS1 (ORCPT ); Mon, 16 Aug 2021 08:18:27 -0400 Received: from verein.lst.de ([213.95.11.211]:54190 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233062AbhHPMS0 (ORCPT ); Mon, 16 Aug 2021 08:18:26 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B0EC36736F; Mon, 16 Aug 2021 14:17:52 +0200 (CEST) Date: Mon, 16 Aug 2021 14:17:52 +0200 From: Christoph Hellwig To: Kari Argillander Cc: Konstantin Komarov , Christoph Hellwig , ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Pali =?iso-8859-1?Q?Roh=E1r?= , Matthew Wilcox Subject: Re: [RFC PATCH 1/4] fs/ntfs3: Use new api for mounting Message-ID: <20210816121752.GA16815@lst.de> References: <20210816024703.107251-1-kari.argillander@gmail.com> <20210816024703.107251-2-kari.argillander@gmail.com> <20210816032351.yo7lkfrwsio3qvjw@kari-VirtualBox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210816032351.yo7lkfrwsio3qvjw@kari-VirtualBox> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 06:23:51AM +0300, Kari Argillander wrote: > > Nls loading is changed a little bit because new api not have default > > optioni for mount parameters. So we need to load nls table before and > > change that if user specifie someting else. > > > > Also try to use fsparam_flag_no as much as possible. This is just nice > > little touch and is not mandatory but it should not make any harm. It > > is just convenient that we can use example acl/noacl mount options. > > I would like that if someone can comment can we do reconfigure so that > we change mount options? Can we example change iocharset and be ok after > that? I have look some other fs drivers and in my eyes it seems to be > quite random if driver should let reconfigure all parameters. Right now > code is that we can reconfigure every mount parameter but I do not know > if this is right call. Reconfiguring non-trivial mount parameters is hard. In general I'd recommend to only allow reconfiguring paramters that a) have user demand for that b) you know what you're actually doing. Something like the iocharset clearly isn't something that makes sense to be changed.