linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aili Yao <yaoaili@kingsoft.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>
Cc: <yaoaili126@gmail.com>, <x86@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: KVM: x86: expose HINTS_REALTIME ablility to qemu
Date: Mon, 16 Aug 2021 14:10:15 +0800	[thread overview]
Message-ID: <20210816141015.31e329e3@alex-virtual-machine> (raw)
In-Reply-To: <20210813175420.62ab2ac2@alex-virtual-machine>

On Fri, 13 Aug 2021 17:54:20 +0800
Aili Yao <yaoaili@kingsoft.com> wrote:

> When I do a test that try to enable hint-dedicated for one VM, but qemu
> says "warning: host doesn't support requested feature:
> CPUID.40000001H:EDX.kvm-hint-dedicated [bit 0]".
> 
> It seems the kernel hasn't expose this ability even when supporting it;
> So expose it.

Sorry, I check it again:
Ihe issue I met is because of my qemu's mis-backport,

In qemu, kvm_arch_get_supported_cpuid() will set the feature bit:
    if (function == KVM_CPUID_FEATURES && reg == R_EDX) {
        ret |= KVM_HINTS_DEDICATED;
        found = 1;
    }
But I have mis-ported the KVM_HINTS_DEDICATED and KVM_HINTS_REALTIME macro; And it lead to
the error I met;

And it's right that kernel don't expose this ability!

Sorry again!


      reply	other threads:[~2021-08-16  6:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  9:54 KVM: x86: expose HINTS_REALTIME ablility to qemu Aili Yao
2021-08-16  6:10 ` Aili Yao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210816141015.31e329e3@alex-virtual-machine \
    --to=yaoaili@kingsoft.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    --cc=yaoaili126@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).