From: Maxime Ripard <email@example.com> To: Andre Przywara <firstname.lastname@example.org> Cc: Chen-Yu Tsai <email@example.com>, Jernej Skrabec <firstname.lastname@example.org>, Rob Herring <email@example.com>, Icenowy Zheng <firstname.lastname@example.org>, Samuel Holland <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, Ondrej Jirman <firstname.lastname@example.org> Subject: Re: [PATCH v8 00/11] arm64: sunxi: Initial Allwinner H616 SoC support Date: Tue, 17 Aug 2021 09:30:30 +0200 [thread overview] Message-ID: <20210817073030.jcvpfipsikllursv@gilmour> (raw) In-Reply-To: <email@example.com> [-- Attachment #1: Type: text/plain, Size: 2508 bytes --] Hi Andre, On Mon, Aug 02, 2021 at 01:38:51AM +0100, Andre Przywara wrote: > On Mon, 26 Jul 2021 16:52:30 +0200 > Maxime Ripard <firstname.lastname@example.org> wrote: > > On Fri, Jul 23, 2021 at 04:38:27PM +0100, Andre Przywara wrote: > > > Hi, > > > > > > another try on the basic Allwinner H616 support, now on top of 5.14-rc1. > > > > > > This time I dropped the USB support from the basic series, to split off > > > the discussion, and simplify the core SoC support. I will post the USB > > > series soon, to be applied on top. > > > I kept the RTC support in, even though this is still under discussion, > > > because this is important to keep future DT files compatible with this > > > kernel. > > > > Honestly, I don't want to support something we don't guarantee if it's > > at the expense of making something we do guarantee more complicated. > > I don't ask for or provide guarantees, but I think we can at least *try* > to keep this compatible. This version works at the moment, and should > also work with future DTs - within the limits of the current driver, so > only using the RC clock. It allows to later improve the accuracy by > adding better input clocks - and later DT/driver combinations can make > use of this. Again, at the expense of having to deal with more bindings combinations in the driver. This driver is already a nightmare to get all the one we have to support already. You asked to keep the same driver, fair enough, but then let's do our best to not make the situation worse there. > > Delaying the clock tree description to sometime in the future will only > > further complicate the probe part of the driver, and there's far too > > many special cases already. > > I don't see how this would complicate probing beyond what Allwinner > brought upon us already anyway: no LOSC crystal input in this package > version, but having this pin in some other SoC sharing this die > (according to some BSP) sources. We can't expect a super clean driver > with those HW design choices. > > If we really cannot keep the DT compatible, fair enough: that's what > it is (there is no guarantee!), but at least we have tried. I mean, we didn't really try though? The whole clock tree has basically a big TODO all over it. I know that it can be hard to figure out. It's why I suggested to rely on fixed clock for the moment as placeholders to get the rest of the series in. But for some reason you don't want to do that either. Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2021-08-17 7:30 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-23 15:38 Andre Przywara 2021-07-23 15:38 ` [PATCH v8 01/11] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ) Andre Przywara 2021-08-16 12:39 ` Lee Jones 2021-07-23 15:38 ` [PATCH v8 02/11] dt-bindings: rtc: sun6i: Add H616 compatible string Andre Przywara 2021-07-23 22:34 ` Rob Herring 2021-07-26 14:41 ` Maxime Ripard 2021-08-02 0:39 ` Andre Przywara 2021-08-17 7:38 ` Maxime Ripard 2021-08-17 8:13 ` Alexandre Belloni 2021-08-19 7:56 ` Maxime Ripard 2021-08-18 9:04 ` Andre Przywara 2021-08-20 3:57 ` Samuel Holland 2021-09-01 7:21 ` Maxime Ripard 2021-07-23 15:38 ` [PATCH v8 03/11] rtc: sun6i: Fix time overflow handling Andre Przywara 2021-07-25 5:44 ` Jernej Škrabec 2021-07-23 15:38 ` [PATCH v8 04/11] rtc: sun6i: Add support for linear day storage Andre Przywara 2021-07-25 5:51 ` Jernej Škrabec 2021-07-23 15:38 ` [PATCH v8 05/11] rtc: sun6i: Add support for broken-down alarm registers Andre Przywara 2021-07-25 6:11 ` Jernej Škrabec 2021-08-02 0:39 ` Andre Przywara 2021-07-23 15:38 ` [PATCH v8 06/11] rtc: sun6i: Add support for RTCs without external LOSCs Andre Przywara 2021-07-25 6:18 ` Jernej Škrabec 2021-07-23 15:38 ` [PATCH v8 07/11] rtc: sun6i: Add Allwinner H616 support Andre Przywara 2021-07-25 6:19 ` Jernej Škrabec 2021-07-23 15:38 ` [PATCH v8 08/11] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Andre Przywara 2021-07-23 15:38 ` [PATCH v8 09/11] dt-bindings: arm: sunxi: Add two H616 board compatible strings Andre Przywara 2021-07-23 15:38 ` [PATCH v8 10/11] arm64: dts: allwinner: h616: Add OrangePi Zero 2 board support Andre Przywara 2021-07-23 15:38 ` [PATCH v8 11/11] arm64: dts: allwinner: h616: Add X96 Mate TV box support Andre Przywara 2021-07-25 16:41 ` [PATCH v8 00/11] arm64: sunxi: Initial Allwinner H616 SoC support Icenowy Zheng 2021-07-26 14:52 ` Maxime Ripard 2021-08-02 0:38 ` Andre Przywara 2021-08-17 7:30 ` Maxime Ripard [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210817073030.jcvpfipsikllursv@gilmour \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v8 00/11] arm64: sunxi: Initial Allwinner H616 SoC support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).