linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Rob Herring <robh@kernel.org>, Icenowy Zheng <icenowy@aosc.io>,
	Samuel Holland <samuel@sholland.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev,
	linux-kernel@vger.kernel.org, Ondrej Jirman <megous@megous.com>,
	devicetree@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org
Subject: Re: [PATCH v9 02/11] dt-bindings: rtc: sun6i: Add H616 compatible string
Date: Wed, 18 Aug 2021 10:15:26 +0200	[thread overview]
Message-ID: <20210818081526.ejzqyz4tqvf2mmdj@gilmour> (raw)
In-Reply-To: <20210802003952.19942-3-andre.przywara@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]

On Mon, Aug 02, 2021 at 01:39:43AM +0100, Andre Przywara wrote:
> Add the obvious compatible name to the existing RTC binding.
> The actual RTC part of the device uses a different day/month/year
> storage scheme, so it's not compatible with the previous devices.
> Also the clock part is quite different, as there is no external 32K LOSC
> oscillator input.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml      | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> index beeb90e55727..d8a6500e5840 100644
> --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> @@ -26,6 +26,7 @@ properties:
>            - const: allwinner,sun50i-a64-rtc
>            - const: allwinner,sun8i-h3-rtc
>        - const: allwinner,sun50i-h6-rtc
> +      - const: allwinner,sun50i-h616-rtc
>  
>    reg:
>      maxItems: 1
> @@ -104,6 +105,19 @@ allOf:
>            minItems: 3
>            maxItems: 3
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: allwinner,sun50i-h616-rtc
> +
> +    then:
> +      properties:
> +        clock-output-names:
> +          minItems: 3
> +          maxItems: 3

The comments I made here on the v7 are still relevant: you only need one
of these two, and the list of clocks should be documented.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2021-08-18  8:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  0:39 [PATCH v9 00/11] arm64: sunxi: Initial Allwinner H616 SoC support Andre Przywara
2021-08-02  0:39 ` [PATCH v9 01/11] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ) Andre Przywara
2021-08-02  7:40   ` Lee Jones
2021-08-02  0:39 ` [PATCH v9 02/11] dt-bindings: rtc: sun6i: Add H616 compatible string Andre Przywara
2021-08-18  8:15   ` Maxime Ripard [this message]
2021-08-02  0:39 ` [PATCH v9 03/11] rtc: sun6i: Fix time overflow handling Andre Przywara
2021-08-02  0:39 ` [PATCH v9 04/11] rtc: sun6i: Add support for linear day storage Andre Przywara
2021-08-02  0:39 ` [PATCH v9 05/11] rtc: sun6i: Add support for broken-down alarm registers Andre Przywara
2021-08-02  0:39 ` [PATCH v9 06/11] rtc: sun6i: Add support for RTCs without external LOSCs Andre Przywara
2021-08-02  0:39 ` [PATCH v9 07/11] rtc: sun6i: Add Allwinner H616 support Andre Przywara
2021-08-02  0:39 ` [PATCH v9 08/11] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Andre Przywara
2021-09-11  4:13   ` Samuel Holland
2021-08-02  0:39 ` [PATCH v9 09/11] dt-bindings: arm: sunxi: Add two H616 board compatible strings Andre Przywara
2021-08-02  0:39 ` [PATCH v9 10/11] arm64: dts: allwinner: h616: Add OrangePi Zero 2 board support Andre Przywara
2021-08-02  0:39 ` [PATCH v9 11/11] arm64: dts: allwinner: h616: Add X96 Mate TV box support Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210818081526.ejzqyz4tqvf2mmdj@gilmour \
    --to=maxime@cerno.tech \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andre.przywara@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=megous@megous.com \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    --subject='Re: [PATCH v9 02/11] dt-bindings: rtc: sun6i: Add H616 compatible string' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).