From: Kees Cook <keescook@chromium.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Miguel Ojeda <ojeda@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Micay <danielmicay@gmail.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>, Dennis Zhou <dennis@kernel.org>,
Tejun Heo <tj@kernel.org>, Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Linux-MM <linux-mm@kvack.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 1/5] Compiler Attributes: Add __alloc_size() for better bounds checking
Date: Wed, 18 Aug 2021 10:58:40 -0700 [thread overview]
Message-ID: <202108181058.2BE1508@keescook> (raw)
In-Reply-To: <CANiq72=ym5ubiXgwt=xyyOSxnPFqgfArJsPyV9juOuwWN+PqCQ@mail.gmail.com>
On Wed, Aug 18, 2021 at 03:07:48PM +0200, Miguel Ojeda wrote:
> On Wed, Aug 18, 2021 at 7:08 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > Clang can additionally use alloc_size to informt the results of
>
> Typo.
>
> > Additionally disables -Wno-alloc-size-larger-than since the allocators
>
> Disables -Walloc-size-larger-than?
>
> > already reject SIZE_MAX, and the compile-time warnings aren't helpful.
>
> Perhaps a bit more context here (and/or in the comment in the
> Makefile) would be nice: i.e. why are they not helpful (even if
> rejected by the allocators).
Thanks for the review! I'll get this all fixed for v2.
--
Kees Cook
next prev parent reply other threads:[~2021-08-18 17:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 5:08 [PATCH 0/5] Add __alloc_size() for better bounds checking Kees Cook
2021-08-18 5:08 ` [PATCH 1/5] Compiler Attributes: " Kees Cook
2021-08-18 13:07 ` Miguel Ojeda
2021-08-18 17:58 ` Kees Cook [this message]
2021-08-18 18:04 ` Nathan Chancellor
2021-08-18 21:04 ` Kees Cook
2021-08-18 5:08 ` [PATCH 2/5] slab: Add __alloc_size attributes " Kees Cook
2021-08-18 5:31 ` Joe Perches
2021-08-18 6:16 ` Kees Cook
2021-08-18 6:30 ` Joe Perches
2021-08-19 0:27 ` Matthew Wilcox
2021-08-19 1:10 ` Joe Perches
2021-08-19 2:16 ` Matthew Wilcox
2021-08-19 2:59 ` Joe Perches
2021-08-18 5:08 ` [PATCH 3/5] mm/page_alloc: " Kees Cook
2021-08-18 5:08 ` [PATCH 4/5] percpu: " Kees Cook
2021-08-18 5:08 ` [PATCH 5/5] mm/vmalloc: " Kees Cook
2021-08-19 9:09 ` [PATCH 0/5] Add __alloc_size() " Christoph Hellwig
2021-08-19 14:18 ` Daniel Micay
2021-08-25 10:01 ` Christoph Lameter
2021-08-25 16:34 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108181058.2BE1508@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=clang-built-linux@googlegroups.com \
--cc=danielmicay@gmail.com \
--cc=dennis@kernel.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).