linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] ARM: dts: keystone-k2*-evm: Fix mdio and dss node status
@ 2021-08-20  9:53 Roger Quadros
  2021-08-20  9:53 ` [PATCH 1/2] ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" Roger Quadros
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Roger Quadros @ 2021-08-20  9:53 UTC (permalink / raw)
  To: ssantosh; +Cc: nm, linux-arm-kernel, devicetree, linux-kernel, Roger Quadros

Hi Santosh,

This series fixes mdio and dss status nodes from "ok" to "okay"

As per Device Tree core schema [1], status parameter of nodes can be either
"okay" or "disabled".

U-boot Driver Model does not recognize status="ok" either and treats
the node as disabled.

[1] https://github.com/devicetree-org/dt-schema/blob/master/schemas/dt-core.yaml#L36

cheers,
-roger

Roger Quadros (2):
  ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
  ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"

 arch/arm/boot/dts/keystone-k2e-evm.dts  | 2 +-
 arch/arm/boot/dts/keystone-k2g-evm.dts  | 2 +-
 arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
 arch/arm/boot/dts/keystone-k2l-evm.dts  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
  2021-08-20  9:53 [PATCH 0/2] ARM: dts: keystone-k2*-evm: Fix mdio and dss node status Roger Quadros
@ 2021-08-20  9:53 ` Roger Quadros
  2021-08-20  9:53 ` [PATCH 2/2] ARM: dts: keystone-k2g-evm: Fix dss " Roger Quadros
  2021-08-20 17:30 ` [PATCH 0/2] ARM: dts: keystone-k2*-evm: Fix mdio and dss node status Nishanth Menon
  2 siblings, 0 replies; 4+ messages in thread
From: Roger Quadros @ 2021-08-20  9:53 UTC (permalink / raw)
  To: ssantosh
  Cc: nm, linux-arm-kernel, devicetree, linux-kernel, Roger Quadros,
	Grygorii Strashko

As per Device Tree core schema [1], status parameter of nodes can be either
"okay" or "disabled".

U-boot Driver Model does not recognize status="ok" either and treats
the node as disabled.

[1] https://github.com/devicetree-org/dt-schema/blob/master/schemas/dt-core.yaml#L36

Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 arch/arm/boot/dts/keystone-k2e-evm.dts  | 2 +-
 arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
 arch/arm/boot/dts/keystone-k2l-evm.dts  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts
index 66fec5f5d081..acac242ebdf7 100644
--- a/arch/arm/boot/dts/keystone-k2e-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2e-evm.dts
@@ -159,7 +159,7 @@
 };
 
 &mdio {
-	status = "ok";
+	status = "okay";
 	ethphy0: ethernet-phy@0 {
 		compatible = "marvell,88E1514", "marvell,88E1510", "ethernet-phy-ieee802.3-c22";
 		reg = <0>;
diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts
index ad4e22afe133..5e85f000acc3 100644
--- a/arch/arm/boot/dts/keystone-k2hk-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts
@@ -183,7 +183,7 @@
 };
 
 &mdio {
-	status = "ok";
+	status = "okay";
 	ethphy0: ethernet-phy@0 {
 		compatible = "marvell,88E1111", "ethernet-phy-ieee802.3-c22";
 		reg = <0>;
diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts
index e200533d26a4..a6cbff4cfe20 100644
--- a/arch/arm/boot/dts/keystone-k2l-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2l-evm.dts
@@ -132,7 +132,7 @@
 };
 
 &mdio {
-	status = "ok";
+	status = "okay";
 	ethphy0: ethernet-phy@0 {
 		compatible = "marvell,88E1514", "marvell,88E1510", "ethernet-phy-ieee802.3-c22";
 		reg = <0>;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
  2021-08-20  9:53 [PATCH 0/2] ARM: dts: keystone-k2*-evm: Fix mdio and dss node status Roger Quadros
  2021-08-20  9:53 ` [PATCH 1/2] ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" Roger Quadros
@ 2021-08-20  9:53 ` Roger Quadros
  2021-08-20 17:30 ` [PATCH 0/2] ARM: dts: keystone-k2*-evm: Fix mdio and dss node status Nishanth Menon
  2 siblings, 0 replies; 4+ messages in thread
From: Roger Quadros @ 2021-08-20  9:53 UTC (permalink / raw)
  To: ssantosh; +Cc: nm, linux-arm-kernel, devicetree, linux-kernel, Roger Quadros

As per Device Tree core schema [1], status parameter of nodes can be either
"okay" or "disabled".

U-boot Driver Model does not recognize status="ok" either and treats
the node as disabled.

[1] https://github.com/devicetree-org/dt-schema/blob/master/schemas/dt-core.yaml#L36

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/keystone-k2g-evm.dts b/arch/arm/boot/dts/keystone-k2g-evm.dts
index d800f26b6275..57680323e202 100644
--- a/arch/arm/boot/dts/keystone-k2g-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2g-evm.dts
@@ -534,7 +534,7 @@
 &dss {
 	pinctrl-names = "default";
 	pinctrl-0 = <&vout_pins>;
-	status = "ok";
+	status = "okay";
 
 	port {
 		dpi_out: endpoint {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] ARM: dts: keystone-k2*-evm: Fix mdio and dss node status
  2021-08-20  9:53 [PATCH 0/2] ARM: dts: keystone-k2*-evm: Fix mdio and dss node status Roger Quadros
  2021-08-20  9:53 ` [PATCH 1/2] ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" Roger Quadros
  2021-08-20  9:53 ` [PATCH 2/2] ARM: dts: keystone-k2g-evm: Fix dss " Roger Quadros
@ 2021-08-20 17:30 ` Nishanth Menon
  2 siblings, 0 replies; 4+ messages in thread
From: Nishanth Menon @ 2021-08-20 17:30 UTC (permalink / raw)
  To: Roger Quadros; +Cc: ssantosh, linux-arm-kernel, devicetree, linux-kernel

On 12:53-20210820, Roger Quadros wrote:
> Hi Santosh,
> 
> This series fixes mdio and dss status nodes from "ok" to "okay"
> 
> As per Device Tree core schema [1], status parameter of nodes can be either
> "okay" or "disabled".
> 
> U-boot Driver Model does not recognize status="ok" either and treats
> the node as disabled.
> 
> [1] https://github.com/devicetree-org/dt-schema/blob/master/schemas/dt-core.yaml#L36


Wondering if it is better to refer to the device tree specification
itself rather than the schema implementation of the specification..


https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
for example.

> 
> cheers,
> -roger
> 
> Roger Quadros (2):
>   ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
>   ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
> 
>  arch/arm/boot/dts/keystone-k2e-evm.dts  | 2 +-
>  arch/arm/boot/dts/keystone-k2g-evm.dts  | 2 +-
>  arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
>  arch/arm/boot/dts/keystone-k2l-evm.dts  | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.17.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-20 17:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20  9:53 [PATCH 0/2] ARM: dts: keystone-k2*-evm: Fix mdio and dss node status Roger Quadros
2021-08-20  9:53 ` [PATCH 1/2] ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" Roger Quadros
2021-08-20  9:53 ` [PATCH 2/2] ARM: dts: keystone-k2g-evm: Fix dss " Roger Quadros
2021-08-20 17:30 ` [PATCH 0/2] ARM: dts: keystone-k2*-evm: Fix mdio and dss node status Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).