From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A50C4338F for ; Fri, 20 Aug 2021 17:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53447610CC for ; Fri, 20 Aug 2021 17:08:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232583AbhHTRJS (ORCPT ); Fri, 20 Aug 2021 13:09:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:43712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231799AbhHTRJM (ORCPT ); Fri, 20 Aug 2021 13:09:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9BD2B610CC; Fri, 20 Aug 2021 17:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629479314; bh=6Ad+ilmKXkBYKGB3YDYi+cYk50uXVwyBdAJ/McR8sZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EIPZ4n/dZwsQlmWUpqPYhQwFaRUfzhGvZfKn0PW/OZe7YeEPC3wfWmiLtZ7x2t8z6 kA9XSKb8dF7fKkO5v8Vyec9FF+UhzhULfPQMY9z0BuEeNiK2fGqn8dAVXsM+1cFqb4 4h0EP/SlhD/26WYauS6CFyPzx5YMviKWCukQ/qDYCStTSxfsONu+WkA1rKSUSMFVNP 4KICGbswo34oyUFlnkbNsG2op/SZRWSGhCkP2dhvP/VKI4VWNblD50yYtXzilo9VHX UuZzPjC9qQpuU5D6rlZTH5B0VU11HaZUFEHvrA/0Bg/L+seYwOZpMjCEnQaBKNINZz dfIXM8qQTvS3A== Date: Fri, 20 Aug 2021 10:08:32 -0700 From: Jakub Kicinski To: Oleksij Rempel Cc: "David S. Miller" , Andrew Lunn , Heiner Kallweit , Russell King , Jarkko Nikula , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net 1/1] net: usb: asix: ax88772: move embedded PHY detection as early as possible Message-ID: <20210820100832.4b548200@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210820095243.2452-1-o.rempel@pengutronix.de> References: <20210820095243.2452-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Aug 2021 11:52:43 +0200 Oleksij Rempel wrote: > Some HW revisions need additional MAC configuration before the embedded PHY > can be enabled. If this is not done, we won't be able to get response > from the internal PHY. > > This issue was detected on chipcode == AX_AX88772_CHIPCODE variant, > where ax88772_hw_reset() was executed with missing embd_phy flag. > > Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support") > Reported-by: Jarkko Nikula > Tested-by: Jarkko Nikula > Signed-off-by: Oleksij Rempel Does not apply to net, please rebase