From: Chun-Jie Chen <chun-jie.chen@mediatek.com> To: Matthias Brugger <matthias.bgg@gmail.com>, Stephen Boyd <sboyd@kernel.org>, Nicolas Boichat <drinkcat@chromium.org>, Rob Herring <robh+dt@kernel.org> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-mediatek@lists.infradead.org>, <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>, <srv_heupstream@mediatek.com>, <Project_Global_Chrome_Upstream_Group@mediatek.com>, Chun-Jie Chen <chun-jie.chen@mediatek.com> Subject: [v2 05/24] clk: mediatek: Fix resource leak in mtk_clk_simple_probe Date: Fri, 20 Aug 2021 19:14:45 +0800 [thread overview] Message-ID: <20210820111504.350-6-chun-jie.chen@mediatek.com> (raw) In-Reply-To: <20210820111504.350-1-chun-jie.chen@mediatek.com> Release clock data when clock driver probe fail to fix possible resource leak. Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com> --- drivers/clk/mediatek/clk-mtk.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c index c3d385c0cfcb..74890759e98c 100644 --- a/drivers/clk/mediatek/clk-mtk.c +++ b/drivers/clk/mediatek/clk-mtk.c @@ -314,7 +314,15 @@ int mtk_clk_simple_probe(struct platform_device *pdev) r = mtk_clk_register_gates(node, mcd->clks, mcd->num_clks, clk_data); if (r) - return r; + goto free_data; - return of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); + if (r) + goto free_data; + + return r; + +free_data: + mtk_free_clk_data(clk_data); + return r; } -- 2.18.0
next prev parent reply other threads:[~2021-08-20 11:17 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-20 11:14 [v2 00/24] Mediatek MT8195 clock support Chun-Jie Chen 2021-08-20 11:14 ` [v2 01/24] dt-bindings: ARM: Mediatek: Add new document bindings of MT8195 clock Chun-Jie Chen 2021-08-23 6:53 ` Chen-Yu Tsai 2021-08-24 14:44 ` Rob Herring 2021-08-20 11:14 ` [v2 02/24] clk: mediatek: Add dt-bindings of MT8195 clocks Chun-Jie Chen 2021-08-24 15:17 ` Rob Herring 2021-08-25 11:39 ` Chen-Yu Tsai 2021-08-20 11:14 ` [v2 03/24] clk: mediatek: Fix corner case of tuner_en_reg Chun-Jie Chen 2021-08-20 11:14 ` [v2 04/24] clk: mediatek: Add API for clock resource recycle Chun-Jie Chen 2021-08-23 6:40 ` Chen-Yu Tsai 2021-08-20 11:14 ` Chun-Jie Chen [this message] 2021-08-23 6:42 ` [v2 05/24] clk: mediatek: Fix resource leak in mtk_clk_simple_probe Chen-Yu Tsai 2021-08-20 11:14 ` [v2 06/24] clk: mediatek: Add MT8195 apmixedsys clock support Chun-Jie Chen 2021-08-23 9:21 ` Chen-Yu Tsai 2021-08-23 9:56 ` Chen-Yu Tsai 2021-08-29 18:26 ` Stephen Boyd 2021-08-20 11:14 ` [v2 07/24] clk: mediatek: Add MT8195 topckgen " Chun-Jie Chen 2021-08-23 11:16 ` Chen-Yu Tsai 2021-08-20 11:14 ` [v2 08/24] clk: mediatek: Add MT8195 peripheral " Chun-Jie Chen 2021-08-23 11:22 ` Chen-Yu Tsai 2021-08-20 11:14 ` [v2 09/24] clk: mediatek: Add MT8195 infrastructure " Chun-Jie Chen 2021-08-23 11:32 ` Chen-Yu Tsai 2021-08-20 11:14 ` [v2 10/24] clk: mediatek: Add MT8195 camsys " Chun-Jie Chen 2021-08-20 11:14 ` [v2 11/24] clk: mediatek: Add MT8195 ccusys " Chun-Jie Chen 2021-08-23 12:13 ` Chen-Yu Tsai 2021-09-10 10:52 ` Chun-Jie Chen 2021-08-20 11:14 ` [v2 12/24] clk: mediatek: Add MT8195 imgsys " Chun-Jie Chen 2021-08-20 11:14 ` [v2 13/24] clk: mediatek: Add MT8195 ipesys " Chun-Jie Chen 2021-08-23 12:20 ` Chen-Yu Tsai 2021-08-20 11:14 ` [v2 14/24] clk: mediatek: Add MT8195 mfgcfg " Chun-Jie Chen 2021-08-23 12:02 ` Chen-Yu Tsai 2021-08-20 11:14 ` [v2 15/24] clk: mediatek: Add MT8195 scp adsp " Chun-Jie Chen 2021-08-23 12:08 ` Chen-Yu Tsai 2021-08-20 11:14 ` [v2 16/24] clk: mediatek: Add MT8195 vdecsys " Chun-Jie Chen 2021-08-23 12:21 ` Chen-Yu Tsai 2021-08-20 11:14 ` [v2 17/24] clk: mediatek: Add MT8195 vdosys0 " Chun-Jie Chen 2021-08-25 10:52 ` Chen-Yu Tsai 2021-08-20 11:14 ` [v2 18/24] clk: mediatek: Add MT8195 vdosys1 " Chun-Jie Chen 2021-08-25 10:55 ` Chen-Yu Tsai 2021-08-20 11:14 ` [v2 19/24] clk: mediatek: Add MT8195 vencsys " Chun-Jie Chen 2021-08-25 11:03 ` Chen-Yu Tsai 2021-09-10 11:09 ` Chun-Jie Chen 2021-09-14 3:47 ` Chen-Yu Tsai 2021-08-20 11:15 ` [v2 20/24] clk: mediatek: Add MT8195 vppsys0 " Chun-Jie Chen 2021-08-25 10:59 ` Chen-Yu Tsai 2021-08-20 11:15 ` [v2 21/24] clk: mediatek: Add MT8195 vppsys1 " Chun-Jie Chen 2021-08-25 11:00 ` Chen-Yu Tsai 2021-08-20 11:15 ` [v2 22/24] clk: mediatek: Add MT8195 wpesys " Chun-Jie Chen 2021-08-25 11:34 ` Chen-Yu Tsai 2021-09-10 11:04 ` Chun-Jie Chen 2021-08-20 11:15 ` [v2 23/24] clk: mediatek: Add MT8195 imp i2c wrapper " Chun-Jie Chen 2021-08-23 12:50 ` Chen-Yu Tsai 2021-08-20 11:15 ` [v2 24/24] clk: mediatek: Add MT8195 apusys " Chun-Jie Chen 2021-08-23 12:48 ` Chen-Yu Tsai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210820111504.350-6-chun-jie.chen@mediatek.com \ --to=chun-jie.chen@mediatek.com \ --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=drinkcat@chromium.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=srv_heupstream@mediatek.com \ --subject='Re: [v2 05/24] clk: mediatek: Fix resource leak in mtk_clk_simple_probe' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).