archive mirror
 help / color / mirror / Atom feed
From: Riccardo Mancini <>
To: Arnaldo Carvalho de Melo <>
Cc: Ian Rogers <>,
	Namhyung Kim <>,
	Riccardo Mancini <>,
	Jiri Olsa <>,
	Peter Zijlstra <>,
	Ingo Molnar <>,
	Mark Rutland <>,
	Alexander Shishkin <>,
	Jiri Olsa <>, Jin Yao <>,
	Song Liu <>,,
Subject: [PATCH] perf config: fix caching and memory leak in perf_home_perfconfig
Date: Fri, 20 Aug 2021 15:08:17 +0200	[thread overview]
Message-ID: <> (raw)

Acaict, perf_home_perfconfig is supposed to cache the result of
home_perfconfig, which returns the default location of perfconfig for
the user, given the HOME environment variable.
However, the current implementation calls home_perfconfig every time
perf_home_perfconfig is called (so no caching is actually performed),
replacing the previous pointer, thus also causing a memory leak.

This patch adds a check of whether either config or failed is set and,
in that case, directly returns config without calling home_perfconfig at
each invocation.

Cc: Jiri Olsa <>
Fixes: f5f03e19ce14fc31 ("perf config: Add perf_home_perfconfig function")
Signed-off-by: Riccardo Mancini <>
 tools/perf/util/config.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index 63d472b336de21d4..6ab670cdf512507e 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -581,6 +581,9 @@ const char *perf_home_perfconfig(void)
 	static const char *config;
 	static bool failed;
+	if (config || failed)
+		return config;
 	config = failed ? NULL : home_perfconfig();
 	if (!config)
 		failed = true;

             reply	other threads:[~2021-08-20 13:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 13:08 Riccardo Mancini [this message]
2021-08-20 14:13 ` [PATCH] perf config: fix caching and memory leak in perf_home_perfconfig Arnaldo Carvalho de Melo
2021-08-20 19:58   ` Riccardo Mancini
2021-08-24 19:26     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).