* [PATCH linux-next] memory:tegra30-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
@ 2021-08-21 3:52 CGEL
2021-08-25 9:48 ` Krzysztof Kozlowski
2021-09-15 7:37 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: CGEL @ 2021-08-21 3:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Thierry Reding, Jonathan Hunter, Dan Carpenter, linux-kernel,
linux-tegra, jing yangyang, Zeal Robot
From: jing yangyang <jing.yangyang@zte.com.cn>
Fix the following coccicheck warning:
./drivers/memory/tegra/tegra30-emc.c:1322:0-23:WARNING:
tegra_emc_debug_max_rate_fops should be defined
with DEFINE_DEBUGFS_ATTRIBUTE
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
---
drivers/memory/tegra/tegra30-emc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c
index 7e21a85..80f98d7 100644
--- a/drivers/memory/tegra/tegra30-emc.c
+++ b/drivers/memory/tegra/tegra30-emc.c
@@ -1289,7 +1289,7 @@ static int tegra_emc_debug_min_rate_set(void *data, u64 rate)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_min_rate_fops,
+DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops,
tegra_emc_debug_min_rate_get,
tegra_emc_debug_min_rate_set, "%llu\n");
@@ -1319,7 +1319,7 @@ static int tegra_emc_debug_max_rate_set(void *data, u64 rate)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_max_rate_fops,
+DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops,
tegra_emc_debug_max_rate_get,
tegra_emc_debug_max_rate_set, "%llu\n");
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] memory:tegra30-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
2021-08-21 3:52 [PATCH linux-next] memory:tegra30-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE CGEL
@ 2021-08-25 9:48 ` Krzysztof Kozlowski
2021-09-15 7:37 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-25 9:48 UTC (permalink / raw)
To: CGEL
Cc: Thierry Reding, Jonathan Hunter, Dan Carpenter, linux-kernel,
linux-tegra, jing yangyang, Zeal Robot
On 21/08/2021 05:52, CGEL wrote:
> From: jing yangyang <jing.yangyang@zte.com.cn>
>
> Fix the following coccicheck warning:
> ./drivers/memory/tegra/tegra30-emc.c:1322:0-23:WARNING:
> tegra_emc_debug_max_rate_fops should be defined
> with DEFINE_DEBUGFS_ATTRIBUTE
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
Thanks for the patch. Same comment as with other one - where is the report?
Best regards,
Krzysztof
> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
> ---
> drivers/memory/tegra/tegra30-emc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c
> index 7e21a85..80f98d7 100644
> --- a/drivers/memory/tegra/tegra30-emc.c
> +++ b/drivers/memory/tegra/tegra30-emc.c
> @@ -1289,7 +1289,7 @@ static int tegra_emc_debug_min_rate_set(void *data, u64 rate)
> return 0;
> }
>
> -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_min_rate_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops,
> tegra_emc_debug_min_rate_get,
> tegra_emc_debug_min_rate_set, "%llu\n");
>
> @@ -1319,7 +1319,7 @@ static int tegra_emc_debug_max_rate_set(void *data, u64 rate)
> return 0;
> }
>
> -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_max_rate_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops,
> tegra_emc_debug_max_rate_get,
> tegra_emc_debug_max_rate_set, "%llu\n");
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] memory:tegra30-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
2021-08-21 3:52 [PATCH linux-next] memory:tegra30-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE CGEL
2021-08-25 9:48 ` Krzysztof Kozlowski
@ 2021-09-15 7:37 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-15 7:37 UTC (permalink / raw)
To: CGEL
Cc: Krzysztof Kozlowski, Thierry Reding, linux-kernel, linux-tegra,
jing yangyang, Jonathan Hunter, Dan Carpenter, Zeal Robot
On Fri, 20 Aug 2021 20:52:23 -0700, CGEL wrote:
> From: jing yangyang <jing.yangyang@zte.com.cn>
>
> Fix the following coccicheck warning:
> ./drivers/memory/tegra/tegra30-emc.c:1322:0-23:WARNING:
> tegra_emc_debug_max_rate_fops should be defined
> with DEFINE_DEBUGFS_ATTRIBUTE
>
> [...]
Applied, thanks!
[1/1] memory:tegra30-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
commit: e12bc3540ad79b2cfc0b801ed16c93b13741d32e
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-15 7:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21 3:52 [PATCH linux-next] memory:tegra30-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE CGEL
2021-08-25 9:48 ` Krzysztof Kozlowski
2021-09-15 7:37 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).