From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Tzvetomir Stoyanov" <tz.stoyanov@gmail.com>,
Tom Zanussi <zanussi@kernel.org>, Shuah Khan <shuah@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v9 4/6] selftests/ftrace: Add test case to test adding and removing of event probe
Date: Sat, 21 Aug 2021 10:40:48 +0900 [thread overview]
Message-ID: <20210821104048.2eeda1067909e7df0771bef6@kernel.org> (raw)
In-Reply-To: <20210820204742.274591200@goodmis.org>
On Fri, 20 Aug 2021 16:46:48 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> Add a test case that adds an event probe, makes sure that it works, and
> then removes it.
>
> Link: https://lore.kernel.org/linux-kselftest/20210819152825.526931866@goodmis.org/
>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: linux-kselftest@vger.kernel.org
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
This looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
> ---
> .../test.d/dynevent/add_remove_eprobe.tc | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc
>
> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc
> new file mode 100644
> index 000000000000..25a3da4eaa44
> --- /dev/null
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc
> @@ -0,0 +1,40 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +# description: Generic dynamic event - add/remove eprobe events
> +# requires: dynamic_events events/syscalls/sys_enter_openat "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README
> +
> +echo 0 > events/enable
> +
> +clear_dynamic_events
> +
> +SYSTEM="syscalls"
> +EVENT="sys_enter_openat"
> +FIELD="filename"
> +EPROBE="eprobe_open"
> +
> +echo "e:$EPROBE $SYSTEM/$EVENT file=+0(\$filename):ustring" >> dynamic_events
> +
> +grep -q "$EPROBE" dynamic_events
> +test -d events/eprobes/$EPROBE
> +
> +echo 1 > events/eprobes/$EPROBE/enable
> +ls
> +echo 0 > events/eprobes/$EPROBE/enable
> +
> +content=`grep '^ *ls-' trace | grep 'file='`
> +nocontent=`grep '^ *ls-' trace | grep 'file=' | grep -v -e '"/' -e '"."'` || true
> +
> +if [ -z "$content" ]; then
> + exit_fail
> +fi
> +
> +if [ ! -z "$nocontent" ]; then
> + exit_fail
> +fi
> +
> +echo "-:$EPROBE" >> dynamic_events
> +
> +! grep -q "$EPROBE" dynamic_events
> +! test -d events/eprobes/$EPROBE
> +
> +clear_trace
> --
> 2.30.2
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-08-21 1:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 20:46 [PATCH v9 0/6] tracing: Creation of event probe Steven Rostedt
2021-08-20 20:46 ` [PATCH v9 1/6] tracing: Add a probe that attaches to trace events Steven Rostedt
2021-08-20 20:46 ` [PATCH v9 2/6] selftests/ftrace: Add clear_dynamic_events() to test cases Steven Rostedt
2021-08-20 20:46 ` [PATCH v9 3/6] selftests/ftrace: Fix requirement check of README file Steven Rostedt
2021-08-21 1:43 ` Masami Hiramatsu
2021-08-20 20:46 ` [PATCH v9 4/6] selftests/ftrace: Add test case to test adding and removing of event probe Steven Rostedt
2021-08-21 1:40 ` Masami Hiramatsu [this message]
2021-08-20 20:46 ` [PATCH v9 5/6] selftests/ftrace: Add selftest for testing eprobe events on synthetic events Steven Rostedt
2021-08-21 1:38 ` Masami Hiramatsu
2021-08-20 20:46 ` [PATCH v9 6/6] selftests/ftrace: Add selftest for testing duplicate eprobes and kprobes Steven Rostedt
2021-08-21 1:41 ` Masami Hiramatsu
2021-08-21 2:18 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210821104048.2eeda1067909e7df0771bef6@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tz.stoyanov@gmail.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).