From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07E7DC432BE for ; Sat, 21 Aug 2021 01:41:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1C4160F45 for ; Sat, 21 Aug 2021 01:41:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240402AbhHUBmf (ORCPT ); Fri, 20 Aug 2021 21:42:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:35512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbhHUBme (ORCPT ); Fri, 20 Aug 2021 21:42:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C5A1361163; Sat, 21 Aug 2021 01:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629510115; bh=HBWduDiPhGmHdP51duukiLFu8daTpY7XH8pt3F5Gdvg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EPN8ZQQg+M64VXwH9EZvhEHX3mwyKpAjPqifcxEHvyklD9mKWVfO0vhS4x0A538IE 89s96x55cAt8P8YvMOPXbMfXq+9ERqlLEvdDrPF/RNYJ/NsB4IOBizcaCWYTkRvwt8 Cn00B/rCLMDZ53lZqmkhOVkGK2uq9vQL3v+1qq4c/SF7JQPiCSQ9Po52uZD1Pw6283 caHoIuglN8fjNyXn3BVsHjo1gp5gFR9ol1i7n7ULUnvHibPR6ea+ovL96zy9RsURJJ 1E3SPUEaGQKroGOGrgf4GYBFeckX064DmRIO5tkzE+VQx9X/a9fRbJqW0S0ulYLxGJ 8wSd0sxNk/hcw== Date: Sat, 21 Aug 2021 10:41:52 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, Ingo Molnar , Andrew Morton , Masami Hiramatsu , "Tzvetomir Stoyanov" , Tom Zanussi , Shuah Khan , Shuah Khan , linux-kselftest@vger.kernel.org Subject: Re: [PATCH v9 6/6] selftests/ftrace: Add selftest for testing duplicate eprobes and kprobes Message-Id: <20210821104152.de68dee1b30a72bf2b0c815f@kernel.org> In-Reply-To: <20210820204742.653288346@goodmis.org> References: <20210820204644.546662591@goodmis.org> <20210820204742.653288346@goodmis.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Aug 2021 16:46:50 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Add a selftest that makes sure that eprobes and kprobes can not be created > with the same group and name as existing events. > > Link: https://lore.kernel.org/linux-kselftest/20210819152825.715290342@goodmis.org/ > > Cc: Shuah Khan > Cc: Shuah Khan > Cc: linux-kselftest@vger.kernel.org > Signed-off-by: Steven Rostedt (VMware) OK, this looks good to me. Acked-by: Masami Hiramatsu Thank you, > --- > .../ftrace/test.d/dynevent/test_duplicates.tc | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc > > diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc > new file mode 100644 > index 000000000000..db522577ff78 > --- /dev/null > +++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc > @@ -0,0 +1,38 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > +# description: Generic dynamic event - check if duplicate events are caught > +# requires: dynamic_events "e[:[/]] . []":README > + > +echo 0 > events/enable > + > +HAVE_KPROBES=0 > + > +if [ -f kprobe_events ]; then > + HAVE_KPROBES=1 > +fi > + > +clear_dynamic_events > + > +# first create dynamic events for eprobes and kprobes. > + > +echo 'e:egroup/eevent syscalls/sys_enter_openat file=+0($filename):ustring' >> dynamic_events > + > +# Test eprobe for same eprobe, existing kprobe and existing event > +! echo 'e:egroup/eevent syscalls/sys_enter_openat file=+0($filename):ustring' >> dynamic_events > +! echo 'e:syscalls/sys_enter_open syscalls/sys_enter_openat file=+0($filename):ustring' >> dynamic_events > + > +if [ $HAVE_KPROBES -eq 1 ]; then > + echo 'p:kgroup/kevent vfs_open file=+0($arg2)' >> dynamic_events > + ! echo 'e:kgroup/kevent syscalls/sys_enter_openat file=+0($filename):ustring' >> dynamic_events > + > +# Test kprobe for same kprobe, existing eprobe and existing event > + ! echo 'p:kgroup/kevent vfs_open file=+0($arg2)' >> dynamic_events > + ! echo 'p:egroup/eevent vfs_open file=+0($arg2)' >> dynamic_events > + ! echo 'p:syscalls/sys_enter_open vfs_open file=+0($arg2)' >> dynamic_events > + > + echo '-:kgroup/kevent' >> dynamic_events > +fi > + > +echo '-:egroup/eevent' >> dynamic_events > + > +clear_trace > -- > 2.30.2 -- Masami Hiramatsu