Hi Mihail, I love your patch! Perhaps something to improve: [auto build test WARNING on 94a853eca720ac9e385e59f27e859b4a01123f58] url: https://github.com/0day-ci/linux/commits/Mihail-Chindris/iio-Add-output-buffer-support-and-DAC-example/20210821-010349 base: 94a853eca720ac9e385e59f27e859b4a01123f58 config: i386-randconfig-p002-20210821 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/b4f124803ed8bfe5936c756ed4c7aa9124a1468a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mihail-Chindris/iio-Add-output-buffer-support-and-DAC-example/20210821-010349 git checkout b4f124803ed8bfe5936c756ed4c7aa9124a1468a # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/iio/industrialio-buffer.c:1415: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * When adding new attributes here, put the at the end, at least until vim +1415 drivers/iio/industrialio-buffer.c 1413 1414 /** > 1415 * When adding new attributes here, put the at the end, at least until 1416 * the code that handles the lengh/length_ro & watermark/watermark_ro 1417 * assignments gets cleaned up. Otherwise these can create some weird 1418 * duplicate attributes errors under some setups. 1419 */ 1420 static struct attribute *iio_buffer_attrs[] = { 1421 &dev_attr_length.attr, 1422 &dev_attr_enable.attr, 1423 &dev_attr_watermark.attr, 1424 &dev_attr_data_available.attr, 1425 &dev_attr_direction.attr, 1426 }; 1427 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org