linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Dillon Min <dillon.minfei@gmail.com>,
	Tzung-Bi Shih <tzungbi@google.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] dt-bindings: sound: rt1015p: correct indentation
Date: Mon, 23 Aug 2021 12:26:15 +0100	[thread overview]
Message-ID: <20210823112615.GD4380@sirena.org.uk> (raw)
In-Reply-To: <20210819101020.26368-2-krzysztof.kozlowski@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

On Thu, Aug 19, 2021 at 12:10:20PM +0200, Krzysztof Kozlowski wrote:
> Use common enum instead of oneOf and correct indentation warning:
>   realtek,rt1015p.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation)

For stuff like this where there's no relationship between the things
being patched it's probably better to just send a bunch of individual
patches rather than a series, it works better with tooling and makes it
clear there's no interdependencies or anything.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2021-08-23 11:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 10:10 [PATCH 1/2] dt-bindings: panel: ili9341: correct indentation Krzysztof Kozlowski
2021-08-19 10:10 ` [PATCH 2/2] dt-bindings: sound: rt1015p: " Krzysztof Kozlowski
2021-08-19 21:52   ` Rob Herring
2021-08-20  6:22     ` Tzung-Bi Shih
2021-08-23 11:26   ` Mark Brown [this message]
2021-08-23 17:37 ` (subset) [PATCH 1/2] dt-bindings: panel: ili9341: " Mark Brown
     [not found]   ` <YSP5UGRATAjuRteM@ravnborg.org>
2021-08-23 19:40     ` Mark Brown
     [not found] ` <YSQA/iR6D/Ej1kWx@ravnborg.org>
2021-08-30 12:26   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210823112615.GD4380@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=airlied@linux.ie \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dillon.minfei@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    --cc=tzungbi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).