From: Marc Kleine-Budde <mkl@pengutronix.de>
To: tangbin <tangbin@cmss.chinamobile.com>
Cc: davem@davemloft.net, wg@grandegger.com, kuba@kernel.org,
kevinbrace@bracecomputerlab.com, romieu@fr.zoreil.com,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] can: mscan: mpc5xxx_can: Useof_device_get_match_data to simplify code
Date: Mon, 23 Aug 2021 15:54:38 +0200 [thread overview]
Message-ID: <20210823135438.kqsrkolixcgepyqq@pengutronix.de> (raw)
In-Reply-To: <eafd35fd-bf71-167a-b1c8-50e3117e4be4@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 2044 bytes --]
On 23.08.2021 21:52:03, tangbin wrote:
> On 2021/8/23 20:37, Marc Kleine-Budde wrote:
> > On 23.08.2021 19:33:38, Tang Bin wrote:
> > > Retrieve OF match data, it's better and cleaner to use
> > > 'of_device_get_match_data' over 'of_match_device'.
> > >
> > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> > Thanks for the patch!
> >
> > LGTM, comment inside.
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> >
> > > ---
> > > drivers/net/can/mscan/mpc5xxx_can.c | 6 ++----
> > > 1 file changed, 2 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c
> > > index e254e04ae..3b7465acd 100644
> > > --- a/drivers/net/can/mscan/mpc5xxx_can.c
> > > +++ b/drivers/net/can/mscan/mpc5xxx_can.c
> > > @@ -279,7 +279,6 @@ static u32 mpc512x_can_get_clock(struct platform_device *ofdev,
> > > static const struct of_device_id mpc5xxx_can_table[];
> > > static int mpc5xxx_can_probe(struct platform_device *ofdev)
> > > {
> > > - const struct of_device_id *match;
> > > const struct mpc5xxx_can_data *data;
> > > struct device_node *np = ofdev->dev.of_node;
> > > struct net_device *dev;
> > > @@ -289,10 +288,9 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev)
> > > int irq, mscan_clksrc = 0;
> > > int err = -ENOMEM;
> > > - match = of_match_device(mpc5xxx_can_table, &ofdev->dev);
> > > - if (!match)
> > > + data = of_device_get_match_data(&ofdev->dev);
> > > + if (!data)
> > > return -EINVAL;
> > Please remove the "BUG_ON(!data)", which comes later.
>
> For this place, may I send another patch to fix this 'BUG_ON()' by itself,
> not in this patch series?
Ok, fine with me.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-08-23 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 11:33 [PATCH 0/3] net: Use of_device_get_match_data to simplify code Tang Bin
2021-08-23 11:33 ` [PATCH 1/3] via-rhine: " Tang Bin
2021-08-23 11:33 ` [PATCH 2/3] via-velocity: " Tang Bin
2021-08-23 11:33 ` [PATCH 3/3] can: mscan: mpc5xxx_can: " Tang Bin
2021-08-23 12:37 ` Marc Kleine-Budde
2021-08-23 13:52 ` [PATCH 3/3] can: mscan: mpc5xxx_can: Useof_device_get_match_data " tangbin
2021-08-23 13:54 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823135438.kqsrkolixcgepyqq@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kevinbrace@bracecomputerlab.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=tangbin@cmss.chinamobile.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).