linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mfd/syscon: Use of_iomap() instead of ioremap()
@ 2021-08-23 14:31 Hector Martin
  2021-08-23 18:30 ` Arnd Bergmann
  2021-09-06  9:56 ` Lee Jones
  0 siblings, 2 replies; 3+ messages in thread
From: Hector Martin @ 2021-08-23 14:31 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: Lee Jones, linux-kernel, Hector Martin

This automatically selects between ioremap() and ioremap_np() on
platforms that require it, such as Apple SoCs.

Signed-off-by: Hector Martin <marcan@marcan.st>
---
 drivers/mfd/syscon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index 765c0210cb52..191fdb87c424 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -60,7 +60,7 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk)
 		goto err_map;
 	}
 
-	base = ioremap(res.start, resource_size(&res));
+	base = of_iomap(np, 0);
 	if (!base) {
 		ret = -ENOMEM;
 		goto err_map;
-- 
2.32.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd/syscon: Use of_iomap() instead of ioremap()
  2021-08-23 14:31 [PATCH] mfd/syscon: Use of_iomap() instead of ioremap() Hector Martin
@ 2021-08-23 18:30 ` Arnd Bergmann
  2021-09-06  9:56 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-08-23 18:30 UTC (permalink / raw)
  To: Hector Martin; +Cc: Arnd Bergmann, Lee Jones, Linux Kernel Mailing List

On Mon, Aug 23, 2021 at 4:32 PM Hector Martin <marcan@marcan.st> wrote:
>
> This automatically selects between ioremap() and ioremap_np() on
> platforms that require it, such as Apple SoCs.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>

Acked-by: Arnd Bergmann <arnd@arndb.de>

Lee, please apply for 5.15 if it's not too late.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd/syscon: Use of_iomap() instead of ioremap()
  2021-08-23 14:31 [PATCH] mfd/syscon: Use of_iomap() instead of ioremap() Hector Martin
  2021-08-23 18:30 ` Arnd Bergmann
@ 2021-09-06  9:56 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2021-09-06  9:56 UTC (permalink / raw)
  To: Hector Martin; +Cc: Arnd Bergmann, linux-kernel

On Mon, 23 Aug 2021, Hector Martin wrote:

> This automatically selects between ioremap() and ioremap_np() on
> platforms that require it, such as Apple SoCs.
> 
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  drivers/mfd/syscon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-06  9:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 14:31 [PATCH] mfd/syscon: Use of_iomap() instead of ioremap() Hector Martin
2021-08-23 18:30 ` Arnd Bergmann
2021-09-06  9:56 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).