linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] netfilter: x_tables: handle xt_register_template() returning an error value
@ 2021-08-23 20:27 Lukas Bulwahn
  2021-08-23 22:26 ` Florian Westphal
  2021-08-25 11:07 ` Pablo Neira Ayuso
  0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2021-08-23 20:27 UTC (permalink / raw)
  To: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
	netfilter-devel, coreteam
  Cc: netdev, clang-built-linux, kernel-janitors, linux-kernel, Lukas Bulwahn

Commit fdacd57c79b7 ("netfilter: x_tables: never register tables by
default") introduces the function xt_register_template(), and in one case,
a call to that function was missing the error-case handling.

Handle when xt_register_template() returns an error value.

This was identified with the clang-analyzer's Dead-Store analysis.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 net/ipv4/netfilter/iptable_mangle.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/ipv4/netfilter/iptable_mangle.c b/net/ipv4/netfilter/iptable_mangle.c
index b52a4c8a14fc..40417a3f930b 100644
--- a/net/ipv4/netfilter/iptable_mangle.c
+++ b/net/ipv4/netfilter/iptable_mangle.c
@@ -112,6 +112,8 @@ static int __init iptable_mangle_init(void)
 {
 	int ret = xt_register_template(&packet_mangler,
 				       iptable_mangle_table_init);
+	if (ret < 0)
+		return ret;
 
 	mangle_ops = xt_hook_ops_alloc(&packet_mangler, iptable_mangle_hook);
 	if (IS_ERR(mangle_ops)) {
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] netfilter: x_tables: handle xt_register_template() returning an error value
  2021-08-23 20:27 [PATCH] netfilter: x_tables: handle xt_register_template() returning an error value Lukas Bulwahn
@ 2021-08-23 22:26 ` Florian Westphal
  2021-08-25 11:07 ` Pablo Neira Ayuso
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Westphal @ 2021-08-23 22:26 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
	netfilter-devel, netdev, clang-built-linux, kernel-janitors,
	linux-kernel

Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> Commit fdacd57c79b7 ("netfilter: x_tables: never register tables by
> default") introduces the function xt_register_template(), and in one case,
> a call to that function was missing the error-case handling.
> 
> Handle when xt_register_template() returns an error value.
> 
> This was identified with the clang-analyzer's Dead-Store analysis.

Fixes: fdacd57c79b7 ("netfilter: x_tables: never register tables by > default")
Reviewed-by: Florian Westphal <fw@strlen.de>

This needs to go to nf-next.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] netfilter: x_tables: handle xt_register_template() returning an error value
  2021-08-23 20:27 [PATCH] netfilter: x_tables: handle xt_register_template() returning an error value Lukas Bulwahn
  2021-08-23 22:26 ` Florian Westphal
@ 2021-08-25 11:07 ` Pablo Neira Ayuso
  1 sibling, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2021-08-25 11:07 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Jozsef Kadlecsik, Florian Westphal, netfilter-devel, coreteam,
	netdev, clang-built-linux, kernel-janitors, linux-kernel

On Mon, Aug 23, 2021 at 10:27:29PM +0200, Lukas Bulwahn wrote:
> Commit fdacd57c79b7 ("netfilter: x_tables: never register tables by
> default") introduces the function xt_register_template(), and in one case,
> a call to that function was missing the error-case handling.
> 
> Handle when xt_register_template() returns an error value.
> 
> This was identified with the clang-analyzer's Dead-Store analysis.

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-25 11:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 20:27 [PATCH] netfilter: x_tables: handle xt_register_template() returning an error value Lukas Bulwahn
2021-08-23 22:26 ` Florian Westphal
2021-08-25 11:07 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).