From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528D6C4320A for ; Tue, 24 Aug 2021 07:59:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A88F613DA for ; Tue, 24 Aug 2021 07:59:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235244AbhHXIAQ (ORCPT ); Tue, 24 Aug 2021 04:00:16 -0400 Received: from verein.lst.de ([213.95.11.211]:50658 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234954AbhHXIAO (ORCPT ); Tue, 24 Aug 2021 04:00:14 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 757AD67373; Tue, 24 Aug 2021 09:59:28 +0200 (CEST) Date: Tue, 24 Aug 2021 09:59:28 +0200 From: Christoph Hellwig To: Kari Argillander Cc: Konstantin Komarov , Christoph Hellwig , ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Pali =?iso-8859-1?Q?Roh=E1r?= , Matthew Wilcox , Christian Brauner Subject: Re: [PATCH v2 2/6] fs/ntfs3: Remove unnecesarry remount flag handling Message-ID: <20210824075928.GB26733@lst.de> References: <20210819002633.689831-1-kari.argillander@gmail.com> <20210819002633.689831-3-kari.argillander@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210819002633.689831-3-kari.argillander@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 19, 2021 at 03:26:29AM +0300, Kari Argillander wrote: > Remove unnecesarry remount flag handling. This does not do anything for > this driver. We have already set SB_NODIRATIME when we fill super. Also > noatime should be set from mount option. Now for some reson we try to > set it when remounting. > > Lazytime part looks like it is copied from f2fs and there is own mount > parameter for it. That is why they use it. We do not set lazytime > anywhere in our code. So basically this just blocks lazytime when > remounting. > > Signed-off-by: Kari Argillander Looks good, Reviewed-by: Christoph Hellwig