From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525C8C4320A for ; Tue, 24 Aug 2021 18:54:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3131E61368 for ; Tue, 24 Aug 2021 18:54:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233775AbhHXSzk (ORCPT ); Tue, 24 Aug 2021 14:55:40 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:40624 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbhHXSzj (ORCPT ); Tue, 24 Aug 2021 14:55:39 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 30D6D1C0B7A; Tue, 24 Aug 2021 20:54:53 +0200 (CEST) Date: Tue, 24 Aug 2021 20:54:52 +0200 From: Pavel Machek To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Parav Pandit , Eli Cohen , Jason Wang , "Michael S . Tsirkin" , Eric Dumazet , syzbot Subject: Re: [PATCH 5.10 10/98] vdpa: Define vdpa mgmt device, ops and a netlink interface Message-ID: <20210824185452.GA15995@duo.ucw.cz> References: <20210824165908.709932-1-sashal@kernel.org> <20210824165908.709932-11-sashal@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <20210824165908.709932-11-sashal@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Parav Pandit >=20 > [ Upstream commit 33b347503f014ebf76257327cbc7001c6b721956 ] >=20 > To add one or more VDPA devices, define a management device which > allows adding or removing vdpa device. A management device defines > set of callbacks to manage vdpa devices. >=20 > To begin with, it defines add and remove callbacks through which a user > defined vdpa device can be added or removed. This looks quite intrusive; is it meant to be in -stable, or is it some kind of mistake? Best regards, Pavel =09 > Signed-off-by: Parav Pandit > Reviewed-by: Eli Cohen > Reviewed-by: Jason Wang > Link: https://lore.kernel.org/r/20210105103203.82508-4-parav@nvidia.com > Signed-off-by: Michael S. Tsirkin >=20 > Including a bugfix: >=20 > vpda: correctly size vdpa_nl_policy >=20 > We need to ensure last entry of vdpa_nl_policy[] > is zero, otherwise out-of-bounds access is hurting us. >=20 > Signed-off-by: Eric Dumazet > Reported-by: syzbot > Cc: Parav Pandit > Cc: Eli Cohen > Cc: Jason Wang > Cc: Michael S. Tsirkin > Link: https://lore.kernel.org/r/20210210134911.4119555-1-eric.dumazet@gma= il.com > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Sasha Levin > --- > drivers/vdpa/Kconfig | 1 + > drivers/vdpa/vdpa.c | 213 +++++++++++++++++++++++++++++++++++++- > include/linux/vdpa.h | 31 ++++++ > include/uapi/linux/vdpa.h | 31 ++++++ > 4 files changed, 275 insertions(+), 1 deletion(-) > create mode 100644 include/uapi/linux/vdpa.h --=20 http://www.livejournal.com/~pavelmachek --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYSVAfAAKCRAw5/Bqldv6 8qy0AJ9Tg8+8GX4JgBwFkgsCWSgTB4SNVACffFIqORPcMOWxfLIoNZ4x6OOipXY= =RNQq -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--