* [PATCH -next] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg()
@ 2021-08-25 6:34 Yang Yingliang
2021-08-26 9:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-08-25 6:34 UTC (permalink / raw)
To: linux-kernel, netdev; +Cc: sgoutham, davem
If otx2_mbox_get_rsp() fails, otx2_set_flowkey_cfg() need return an
error code.
Fixes: e7938365459f ("octeontx2-pf: Fix algorithm index in MCAM rules with RSS action")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
index f630e5713025..ad79d2c05ca4 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
@@ -289,8 +289,10 @@ int otx2_set_flowkey_cfg(struct otx2_nic *pfvf)
rsp = (struct nix_rss_flowkey_cfg_rsp *)
otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
- if (IS_ERR(rsp))
+ if (IS_ERR(rsp)) {
+ err = PTR_ERR(rsp);
goto fail;
+ }
pfvf->hw.flowkey_alg_idx = rsp->alg_idx;
fail:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg()
2021-08-25 6:34 [PATCH -next] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg() Yang Yingliang
@ 2021-08-26 9:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-26 9:50 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, netdev, sgoutham, davem
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 25 Aug 2021 14:34:47 +0800 you wrote:
> If otx2_mbox_get_rsp() fails, otx2_set_flowkey_cfg() need return an
> error code.
>
> Fixes: e7938365459f ("octeontx2-pf: Fix algorithm index in MCAM rules with RSS action")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>
> [...]
Here is the summary with links:
- [-next] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg()
https://git.kernel.org/netdev/net-next/c/5e8243e66b4d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-26 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 6:34 [PATCH -next] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg() Yang Yingliang
2021-08-26 9:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).