From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C67CAC4338F for ; Wed, 25 Aug 2021 08:53:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2E3B61103 for ; Wed, 25 Aug 2021 08:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233617AbhHYIye (ORCPT ); Wed, 25 Aug 2021 04:54:34 -0400 Received: from verein.lst.de ([213.95.11.211]:55333 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231963AbhHYIyd (ORCPT ); Wed, 25 Aug 2021 04:54:33 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 0C18267357; Wed, 25 Aug 2021 10:53:46 +0200 (CEST) Date: Wed, 25 Aug 2021 10:53:45 +0200 From: "hch@lst.de" To: sasaki tatsuya Cc: "kbusch@kernel.org" , "axboe@fb.com" , "hch@lst.de" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] nvme: update keep alive interval when kato is modified Message-ID: <20210825085345.GA31419@lst.de> References: <526a1a756d6c4643b15b1b305cc32817@kioxia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <526a1a756d6c4643b15b1b305cc32817@kioxia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Any reason we can't just call this from nvme_passthru_end instead of inventing a new API? Right now the nvmet passthrough code never uses the underlying keep alive code, so it doesn't make a difference, but I expect we'll need more handling for passthrough commands like this, and we might also grow more users (e.g. the io_uring based passthrough).