From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Larry Finger' <Larry.Finger@lwfinger.net>,
Aakash Hemadri <aakashhemadri123@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Phillip Potter <phil@philpotter.co.uk>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] staging: r8188eu: cast to restricted __be32
Date: Wed, 25 Aug 2021 12:19:21 +0300 [thread overview]
Message-ID: <20210825091921.GR1931@kadam> (raw)
In-Reply-To: <ba4668725f944d12843529f0b0d4a8a2@AcuMS.aculab.com>
On Wed, Aug 25, 2021 at 09:13:44AM +0000, David Laight wrote:
> From: Larry Finger
> > Sent: 23 August 2021 15:24
> >
> > On 8/23/21 3:44 AM, Aakash Hemadri wrote:
> > > On 21/08/21 09:48PM, Aakash Hemadri wrote:
> > >> Fix sparse warning:
> > >>> rtw_br_ext.c:836:54: warning: cast to restricted __be32
> > >>
> > >> dhpch->cookie is be32, change it's type.
> ...
> > >> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> > >> index f6d1f6029ec3..f65d94bfa286 100644
> > >> --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> > >> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> ...
> > >> @@ -671,7 +671,7 @@ void dhcp_flag_bcast(struct adapter *priv, struct sk_buff *skb)
> > >> (udph->dest == __constant_htons(SERVER_PORT))) { /* DHCP request */
> > >> struct dhcpMessage *dhcph =
> > >> (struct dhcpMessage *)((size_t)udph + sizeof(struct udphdr));
>
> This assignment looks dubious at best - WTF is (size_t) for?
> I don't seem to have a source tree with this driver in it (probably only in 'next'?).
> I suspect it should be:
> struct dhcp_message *dhcph = (void *)(udph + 1);
Those are equivalent. Either way works.
regards,
dan carpenter
next prev parent reply other threads:[~2021-08-25 9:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 16:18 [PATCH v3 0/5] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-21 16:18 ` [PATCH v3 1/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-21 17:23 ` Phillip Potter
2021-08-21 16:18 ` [PATCH v3 2/5] staging: r8188eu: cast to restricted __be32 Aakash Hemadri
2021-08-23 8:44 ` Aakash Hemadri
2021-08-23 14:24 ` Larry Finger
2021-08-25 9:13 ` David Laight
2021-08-25 9:19 ` Dan Carpenter [this message]
2021-08-25 10:21 ` David Laight
2021-08-25 10:39 ` Dan Carpenter
2021-08-21 16:18 ` [PATCH v3 3/5] staging: r8188eu: incorrect type in csum_ipv6_magic Aakash Hemadri
2021-08-21 16:18 ` [PATCH v3 4/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-21 16:18 ` [PATCH v3 5/5] staging: r8188eu: incorrect type in assignment Aakash Hemadri
2021-08-22 20:25 ` Larry Finger
2021-08-21 16:20 ` [PATCH v3 0/5] staging: r8188eu: fix sparse warnings Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825091921.GR1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=David.Laight@ACULAB.COM \
--cc=Larry.Finger@lwfinger.net \
--cc=aakashhemadri123@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).