From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E06FC43216 for ; Fri, 27 Aug 2021 03:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BE6B60F5B for ; Fri, 27 Aug 2021 03:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244071AbhH0DGw (ORCPT ); Thu, 26 Aug 2021 23:06:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231607AbhH0DGu (ORCPT ); Thu, 26 Aug 2021 23:06:50 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9304EC061757 for ; Thu, 26 Aug 2021 20:06:02 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id c4so3042607plh.7 for ; Thu, 26 Aug 2021 20:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=B3i7idO8QqKhjt0ThMO0ce5R45fYSfUmsl0FexLZ5s0=; b=bTEyYRvY1cWcwoZEZ2moTg1MjvMRYK8rR2S5dUEOaEfvquXEgZBwJP6Pk1JE+xxszK Gh2K0JCV4U6S6UY6uJjQunU41ghVesKm1+1TyAmkjVlwsbOIqY7QRq5SpcdAeERa95zm 65SJep8SkvCVT7UaMaZ3Pke9nQreBI6ybUrcnCamJXe5wiLQdQm6xfk5ofI5favfLZTl 9yTQbn509s3wcC6a42QCUHj2d1cU0FxlgQFFOqMcbgBHIWwK3abPu7ZPNSGt+lEv2dFW hUrQ2RHm+beAGZ4f4+rJZ3XxBqgJgfgKwNR+ZmfiXcNvKOxNgpgj3X5CbYCr/9c8LF4A 9hig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=B3i7idO8QqKhjt0ThMO0ce5R45fYSfUmsl0FexLZ5s0=; b=VEb7Uyucrx2L3xS3Envl3l4/yXQjEBEhQ56rx/qFSZi8XR28D1ZRizMOx1Zt9nhUkX IT00mRgsA5iepGJTiD/j9M7vHQWbwE/U45EUenORjFMGxT93n5VqlKm8eyMSdi99dN2F Mb24QoWRsdM8cZiKlGrW9RnDcEoZ+TH4Z4/tO8tY/FRwt2uvfWdW8VO6KiCByi1zQSUl H/ffJYnTCrfPfX1nvXE3OCF8DzNjW4gni4+emTYXzA4FtmsIq7UmBB47IzkMl5ViAcrC QZegQlvSPhoz4iE/pzl7rQnNV1uxksVujO7xzz6W2h3NfHzvFl9sy0JXQyEP/sR5+gO4 K3hQ== X-Gm-Message-State: AOAM533QwgpGMPRMkVfsY6XwwjsIk6jUSeh7ejEM2lAAEq+61C/TTJwk iYsDcohBsVIBbGcj2H16GqnRsg== X-Google-Smtp-Source: ABdhPJwi/AXRYp0dh7EOBaZcQmdGOm65HoIu+HLQTJxX6eLLRbofgCP5WSIT9+znxWkDp2OZLm3HfA== X-Received: by 2002:a17:90a:6a01:: with SMTP id t1mr8009301pjj.31.1630033562037; Thu, 26 Aug 2021 20:06:02 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id z12sm4262715pfe.79.2021.08.26.20.06.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 20:06:01 -0700 (PDT) Date: Fri, 27 Aug 2021 08:35:57 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Ulf Hansson , "Rafael J. Wysocki" , Kevin Hilman , Viresh Kumar , Stephen Boyd , Nishanth Menon , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v9 5/8] soc/tegra: pmc: Implement get_performance_state() callback Message-ID: <20210827030557.aymjkky7athjxpow@vireshk-i7> References: <20210827013415.24027-1-digetx@gmail.com> <20210827013415.24027-6-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210827013415.24027-6-digetx@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27-08-21, 04:34, Dmitry Osipenko wrote: > + clk_opp_table = dev_pm_opp_set_clkname(dev, NULL); > + if (IS_ERR(clk_opp_table)) { > + dev_err(dev, "failed to set OPP clk: %pe\n", clk_opp_table); > + ret = PTR_ERR(clk_opp_table); > + goto put_hw; > + } Why do you need to do it ? OPP core already does this automatically. -- viresh