From: Stefano Garzarella <sgarzare@redhat.com>
To: Andra Paraschiv <andraprs@amazon.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Alexandru Ciobotaru <alcioa@amazon.com>,
Greg KH <gregkh@linuxfoundation.org>,
Kamal Mostafa <kamal@canonical.com>,
Alexandru Vasile <lexnv@amazon.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>, kvm <kvm@vger.kernel.org>,
ne-devel-upstream <ne-devel-upstream@amazon.com>
Subject: Re: [PATCH v1 2/3] nitro_enclaves: Update documentation for Arm support
Date: Fri, 27 Aug 2021 09:21:44 +0200 [thread overview]
Message-ID: <20210827072144.gqncsq42vfpzmoxl@steredhat> (raw)
In-Reply-To: <20210826173451.93165-3-andraprs@amazon.com>
On Thu, Aug 26, 2021 at 08:34:50PM +0300, Andra Paraschiv wrote:
>Add references for hugepages and booting steps for Arm.
>
>Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
>---
> Documentation/virt/ne_overview.rst | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
If you need to respin, maybe we can add a little section with supported
architectures (x86, ARM64).
Stefano
>
>diff --git a/Documentation/virt/ne_overview.rst b/Documentation/virt/ne_overview.rst
>index 39b0c8fe2654a..2777da1fb0ad1 100644
>--- a/Documentation/virt/ne_overview.rst
>+++ b/Documentation/virt/ne_overview.rst
>@@ -43,8 +43,8 @@ for the enclave VM. An enclave does not have persistent storage attached.
> The memory regions carved out of the primary VM and given to an enclave need to
> be aligned 2 MiB / 1 GiB physically contiguous memory regions (or multiple of
> this size e.g. 8 MiB). The memory can be allocated e.g. by using hugetlbfs from
>-user space [2][3]. The memory size for an enclave needs to be at least 64 MiB.
>-The enclave memory and CPUs need to be from the same NUMA node.
>+user space [2][3][7]. The memory size for an enclave needs to be at least
>+64 MiB. The enclave memory and CPUs need to be from the same NUMA node.
>
> An enclave runs on dedicated cores. CPU 0 and its CPU siblings need to remain
> available for the primary VM. A CPU pool has to be set for NE purposes by an
>@@ -61,7 +61,7 @@ device is placed in memory below the typical 4 GiB.
> The application that runs in the enclave needs to be packaged in an enclave
> image together with the OS ( e.g. kernel, ramdisk, init ) that will run in the
> enclave VM. The enclave VM has its own kernel and follows the standard Linux
>-boot protocol [6].
>+boot protocol [6][8].
>
> The kernel bzImage, the kernel command line, the ramdisk(s) are part of the
> Enclave Image Format (EIF); plus an EIF header including metadata such as magic
>@@ -93,3 +93,5 @@ enclave process can exit.
> [4] https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html
> [5] https://man7.org/linux/man-pages/man7/vsock.7.html
> [6] https://www.kernel.org/doc/html/latest/x86/boot.html
>+[7] https://www.kernel.org/doc/html/latest/arm64/hugetlbpage.html
>+[8] https://www.kernel.org/doc/html/latest/arm64/booting.html
>--
>2.20.1 (Apple Git-117)
>
>
>
>
>Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
>
next prev parent reply other threads:[~2021-08-27 7:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 17:34 [PATCH v1 0/3] nitro_enclaves: Add support for Arm64 Andra Paraschiv
2021-08-26 17:34 ` [PATCH v1 1/3] nitro_enclaves: Enable Arm support Andra Paraschiv
2021-08-27 7:06 ` Stefano Garzarella
2021-08-27 8:43 ` Greg KH
2021-08-27 10:19 ` Paraschiv, Andra-Irina
2021-08-26 17:34 ` [PATCH v1 2/3] nitro_enclaves: Update documentation for " Andra Paraschiv
2021-08-27 7:21 ` Stefano Garzarella [this message]
2021-08-27 9:35 ` Paraschiv, Andra-Irina
2021-08-26 17:34 ` [PATCH v1 3/3] nitro_enclaves: Add fixes for checkpatch and docs reports Andra Paraschiv
2021-08-26 17:51 ` Vitaly Kuznetsov
2021-08-26 18:22 ` Paraschiv, Andra-Irina
2021-08-27 8:43 ` Greg KH
2021-08-27 10:22 ` Paraschiv, Andra-Irina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210827072144.gqncsq42vfpzmoxl@steredhat \
--to=sgarzare@redhat.com \
--cc=alcioa@amazon.com \
--cc=andraprs@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=kamal@canonical.com \
--cc=kvm@vger.kernel.org \
--cc=lexnv@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ne-devel-upstream@amazon.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).