From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE88C4320E for ; Fri, 27 Aug 2021 13:30:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59FE560FC4 for ; Fri, 27 Aug 2021 13:30:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245211AbhH0NbD (ORCPT ); Fri, 27 Aug 2021 09:31:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245127AbhH0NbC (ORCPT ); Fri, 27 Aug 2021 09:31:02 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EE8DC0613D9 for ; Fri, 27 Aug 2021 06:30:13 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id ew6so3958388qvb.5 for ; Fri, 27 Aug 2021 06:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9hYvHFGz/V7D23iiTPTOyxcZm7pKUcDRg4kDhPveMaM=; b=RWh3PyaLn9DmYFUvWMAb0sMx7t5tv8neu2ri9D8mJwjUh0f9X4mBOK1mWoSNx+Xk7Q UXygO2RUgsM9ytHw0J7ZnZXf2r3UP4CjRgIHdV2VX/t+bSo6kamNRr5JE5kNDltUDNzn WQgF2d+L0cB45zjDOFEV11+rf/T7+4zgjItd3QTdskgaWTbyVTVvxaCh837ERZ9KLWWx 6TAPmCSOQ6wzP73NwO/nlGoXEsh1OPCVaa9p1VGWwEwyT1w8H6tsGbZ3QUOGbnXVXzFe STjKaFkm5jV0/3qBR3EBlTYcZnURiYHMgxlqQvSKJJpwNGztKUytgfSlnkTIo0X69uPm QMFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9hYvHFGz/V7D23iiTPTOyxcZm7pKUcDRg4kDhPveMaM=; b=NCk85rp4xsPYv821JJEzRgG0Hs65JIakKYMslBg9A7GXIT0X5ml//ZbQYtImalo9hf ovRyTIrbGkh2CPP7qhAMtTmcoccgimWnFaHGXZ9jaqUh7dc/qoFZnUlMRVg2+2VAo6tU u7tKal3EeILxvtEeEktBeDvHI/HubYky2w3nU2maFEamiQrrCnJOLtJPOkZIFxJGRp4M ATf9+6FZozlm7acg70CiXOojkYUz+9goI56Y53mgAwL23Df0VbJesmKfuOwYY/RSOEYH o3C57mxrlUvQZygbC9WZ6vNK184aXHaVUkSAxgB/EApjnWeZaFQsNG1buGL4yNvnzPe3 lRKg== X-Gm-Message-State: AOAM532U+0AzsYGkJWs/l7IZoph0NgGu2/+gqGn1XSdOY7VdW7FTVEle YmnjQ/eQpk9FGPfDn91g5EtGOCBE9ftfCQ== X-Google-Smtp-Source: ABdhPJy6C+imSV9BJygXNb/9syIQPPZVv3Rskg/63cA9hZ4wB9eYt23ZeyxBKJWpGeqjdoeuyRZmDA== X-Received: by 2002:ad4:5aee:: with SMTP id c14mr7922342qvh.19.1630071012375; Fri, 27 Aug 2021 06:30:12 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id q184sm4865997qkd.35.2021.08.27.06.30.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Aug 2021 06:30:11 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mJbvv-005gvU-41; Fri, 27 Aug 2021 10:30:11 -0300 Date: Fri, 27 Aug 2021 10:30:11 -0300 From: Jason Gunthorpe To: Ross Philipson Cc: linux-kernel@vger.kernel.org, x86@kernel.org, iommu@lists.linux-foundation.org, linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com Subject: Re: [PATCH v4 14/14] tpm: Allow locality 2 to be set when initializing the TPM for Secure Launch Message-ID: <20210827133011.GJ1200268@ziepe.ca> References: <1630070917-9896-1-git-send-email-ross.philipson@oracle.com> <1630070917-9896-15-git-send-email-ross.philipson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1630070917-9896-15-git-send-email-ross.philipson@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 27, 2021 at 09:28:37AM -0400, Ross Philipson wrote: > The Secure Launch MLE environment uses PCRs that are only accessible from > the DRTM locality 2. By default the TPM drivers always initialize the > locality to 0. When a Secure Launch is in progress, initialize the > locality to 2. > > Signed-off-by: Ross Philipson > --- > drivers/char/tpm/tpm-chip.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) Global state like this seems quite dangerous, shouldn't the locality be selected based on the PCR being accessed, or passed down from higher up in the call chain? Jason