From: Kalle Valo <firstname.lastname@example.org> To: Zenghui Yu <email@example.com> Cc: <firstname.lastname@example.org>, <email@example.com>, <firstname.lastname@example.org>, <email@example.com>, <firstname.lastname@example.org>, <email@example.com>, Zenghui Yu <firstname.lastname@example.org> Subject: Re: [PATCH 1/2] bcma: Fix memory leak for internally-handled cores Date: Sun, 29 Aug 2021 11:45:19 +0000 (UTC) [thread overview] Message-ID: <20210829114519.46822C4360D@smtp.codeaurora.org> (raw) In-Reply-To: <email@example.com> Zenghui Yu <firstname.lastname@example.org> wrote: > kmemleak reported that dev_name() of internally-handled cores were leaked > on driver unbinding. Let's use device_initialize() to take refcounts for > them and put_device() to properly free the related stuff. > > While looking at it, there's another potential issue for those which should > be *registered* into driver core. If device_register() failed, we put > device once and freed bcma_device structures. In bcma_unregister_cores(), > they're treated as unregistered and we hit both UAF and double-free. That > smells not good and has also been fixed now. > > Fixes: ab54bc8460b5 ("bcma: fill core details for every device") > Signed-off-by: Zenghui Yu <email@example.com> 2 patches applied to wireless-drivers-next.git, thanks. b63aed3ff195 bcma: Fix memory leak for internally-handled cores 9fc8048c56f3 bcma: Drop the unused parameter of bcma_scan_read32() -- https://firstname.lastname@example.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-08-29 11:45 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-27 2:52 two small bcma patches Zenghui Yu 2021-07-27 2:52 ` [PATCH 1/2] bcma: Fix memory leak for internally-handled cores Zenghui Yu 2021-08-21 3:28 ` Zenghui Yu 2021-08-21 10:05 ` Kalle Valo 2021-08-23 3:56 ` Zenghui Yu 2021-08-29 11:45 ` Kalle Valo [this message] 2021-07-27 2:52 ` [PATCH 2/2] bcma: Drop the unused parameter of bcma_scan_read32() Zenghui Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210829114519.46822C4360D@smtp.codeaurora.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 1/2] bcma: Fix memory leak for internally-handled cores' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).