From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22CA0C432BE for ; Sun, 29 Aug 2021 17:13:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDE8160F51 for ; Sun, 29 Aug 2021 17:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235885AbhH2ROs (ORCPT ); Sun, 29 Aug 2021 13:14:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbhH2ROr (ORCPT ); Sun, 29 Aug 2021 13:14:47 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DE73C061575 for ; Sun, 29 Aug 2021 10:13:55 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id p15so21564701ljn.3 for ; Sun, 29 Aug 2021 10:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=X3+Hge5VWCPxleA7QjQ9uJdJi5TXCLwleImqMNApEkI=; b=b9XXk5TcEVP5nklPH7fPEnLD9pWgNcZ5Yhx5UUR/PFUhm1m6N7k6QSm050VxqTFXLk je0jH7RFFDFKjdUCyaMUBI7pKf3v6VpE1Wn55cfI3WxiGveSr8tJSCNX77FmlOW1FlBf MVk1EFVvCVQVe6W4GnHsVMvJbun2843NRqMADbS9l0XplcFn2Rc4yeU4dW/xj75d9SWv W1t0Br8TUxliR1k+3JaEGARUPotYG2t0NdKbeMMnhY/dAM27T99nuILA4H1ylU8TJu8o bNSEMS2WycL8IjI4XwWDH27EA8XRYQ8d4WiO428jVXZolxdzvbuGbdPqzwV1iiDaPenG GsVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=X3+Hge5VWCPxleA7QjQ9uJdJi5TXCLwleImqMNApEkI=; b=rm02ojtmGwVKheaBh08nhcIGztvRmSOH+70gIYyzILHMgnfH+fSLf0o1R4J2cxovT7 b+0Qen5C2SSS+QHK3lfcTOm6RYsfYYuw5YJW4Krf/E22RaOjY1CDMr8EcxNUShuX/Tsm h4ehzPY5z8vRpQD8OBGPofEx1dNVdh4se5hk45XWgHsr43fmXj9FI1V4YEni8LnZoYr0 z0C7ltz93oV+LpVz21PWzynGE33T4Rpi6CIUPTF8Xw+JuKSyKRsAhyyvJfYBcRdb9txt g/xCWxAFUhjQ7BHYFX7vGSOuIeIggojW0aqMIBSZEgWlgbC9Ezp9LfdLlLZz4Ldgz9ZB SJ/w== X-Gm-Message-State: AOAM530INchMfL7aYm4fGPYslWISGtENHPKg86jxJQezq4dDRTcTLgk2 PSyJmRh3WootTILGEWf7vXSX0P9Zn1Ff1w== X-Google-Smtp-Source: ABdhPJy2H5bWSLCuOrDu2NMN5yvggl2SXiJ+2JQBVZb/zSks0gALPhVpqK3lolW8qs7MQ+BvRQgXIw== X-Received: by 2002:a2e:90da:: with SMTP id o26mr16725947ljg.504.1630257233635; Sun, 29 Aug 2021 10:13:53 -0700 (PDT) Received: from kari-VirtualBox (85-23-89-224.bb.dnainternet.fi. [85.23.89.224]) by smtp.gmail.com with ESMTPSA id n15sm1131731lfq.270.2021.08.29.10.13.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Aug 2021 10:13:53 -0700 (PDT) Date: Sun, 29 Aug 2021 20:13:51 +0300 From: Kari Argillander To: Saurav Girepunje Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, straube.linux@gmail.com, ross.schm.dev@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH v4] staging: r8188eu: core: remove null check before vfree Message-ID: <20210829171351.u63zoaqa3x5qfodt@kari-VirtualBox> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 29, 2021 at 10:30:09PM +0530, Saurav Girepunje wrote: > Remove NULL check. NULL check before freeing function is not needed. > Correct the indentation. > > Signed-off-by: Saurav Girepunje > --- > > ChangeLog V4: > - Add Change log below --- line > > ChangeLog V3: > - Add change log. > > ChangeLog V2: > - Correct the indentation. You need "---" here also. So everything what is between --- here --- will be ignored when you apply patch. This is good place to write changelog, if you have tested this with real hardware, if you have any guestions about your own implementation etc. > > drivers/staging/r8188eu/core/rtw_sta_mgt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c b/drivers/staging/r8188eu/core/rtw_sta_mgt.c > index f6dffed53a60..c3600cb1790a 100644 > --- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c > +++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c > @@ -155,9 +155,8 @@ u32 _rtw_free_sta_priv(struct sta_priv *pstapriv) > spin_unlock_bh(&pstapriv->sta_hash_lock); > /*===============================*/ > > - if (pstapriv->pallocated_stainfo_buf) > - vfree(pstapriv->pallocated_stainfo_buf); > - } > + vfree(pstapriv->pallocated_stainfo_buf); > + } > > return _SUCCESS; > } > -- > 2.32.0 >