From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 440E8C4320A for ; Mon, 30 Aug 2021 09:57:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25BD26105A for ; Mon, 30 Aug 2021 09:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235983AbhH3J6C convert rfc822-to-8bit (ORCPT ); Mon, 30 Aug 2021 05:58:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:49080 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbhH3J6A (ORCPT ); Mon, 30 Aug 2021 05:58:00 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 50A6660525; Mon, 30 Aug 2021 09:57:03 +0000 (UTC) Date: Mon, 30 Aug 2021 11:00:15 +0100 From: Jonathan Cameron To: "Sa, Nuno" Cc: Miquel Raynal , Lars-Peter Clausen , Thomas Petazzoni , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH 02/16] iio: adc: max1027: Fix the number of max1X31 channels Message-ID: <20210830110015.787e0abe@jic23-huawei> In-Reply-To: References: <20210818111139.330636-1-miquel.raynal@bootlin.com> <20210818111139.330636-3-miquel.raynal@bootlin.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Aug 2021 07:03:40 +0000 "Sa, Nuno" wrote: > > -----Original Message----- > > From: Miquel Raynal > > Sent: Wednesday, August 18, 2021 1:11 PM > > To: Jonathan Cameron ; Lars-Peter Clausen > > > > Cc: Thomas Petazzoni ; linux- > > iio@vger.kernel.org; linux-kernel@vger.kernel.org; Miquel Raynal > > ; stable@vger.kernel.org > > Subject: [PATCH 02/16] iio: adc: max1027: Fix the number of max1X31 > > channels > > > > [External] > > > > The macro MAX1X29_CHANNELS() already calls > > MAX1X27_CHANNELS(). > > Calling MAX1X27_CHANNELS() before MAX1X29_CHANNELS() in the > > definition > > of MAX1X31_CHANNELS() declares the first 8 channels twice. So drop > > this > > extra call from the MAX1X31 channels list definition. > > > > Fixes: 7af5257d8427 ("iio: adc: max1027: Prepare the introduction of > > different resolutions") > > Cc: stable@vger.kernel.org > > Signed-off-by: Miquel Raynal > > --- > > drivers/iio/adc/max1027.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c > > index 4a42d140a4b0..b753658bb41e 100644 > > --- a/drivers/iio/adc/max1027.c > > +++ b/drivers/iio/adc/max1027.c > > @@ -142,7 +142,6 @@ MODULE_DEVICE_TABLE(of, > > max1027_adc_dt_ids); > > MAX1027_V_CHAN(11, depth) > > > > #define MAX1X31_CHANNELS(depth) \ > > - MAX1X27_CHANNELS(depth), \ > > MAX1X29_CHANNELS(depth), \ > > MAX1027_V_CHAN(12, depth), \ > > MAX1027_V_CHAN(13, depth), \ > > -- > > 2.27.0 > > Reviewed-by: Nuno Sá > I guess we don't have many users of these devices as I would have expected this to blow up spectacularly. Ah well. Applied to the fixes-togreg branch of iio.git Thanks, Jonathan