* linux-next: build warning after merge of the chrome-platform tree
@ 2021-08-23 5:21 Stephen Rothwell
2021-08-30 7:21 ` Stephen Rothwell
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2021-08-23 5:21 UTC (permalink / raw)
To: Benson Leung, Guenter Roeck, Enric Balletbo i Serra, Dmitry Torokhov
Cc: Gwendal Grignou, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 8631 bytes --]
Hi all,
After merging the chrome-platform tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from include/trace/define_trace.h:102,
from drivers/platform/chrome/cros_ec_trace.h:178,
from drivers/platform/chrome/cros_ec_trace.c:215:
drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_sensorhub_timestamp':
drivers/platform/chrome/./cros_ec_trace.h:95:12: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'u32' {aka 'unsigned int'} [-Wformat=]
95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
399 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
80 | PARAMS(print)); \
| ^~~~~~
drivers/platform/chrome/./cros_ec_trace.h:74:1: note: in expansion of macro 'TRACE_EVENT'
74 | TRACE_EVENT(cros_ec_sensorhub_timestamp,
| ^~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:95:2: note: in expansion of macro 'TP_printk'
95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
| ^~~~~~~~~
In file included from include/trace/trace_events.h:433,
from include/trace/define_trace.h:102,
from drivers/platform/chrome/cros_ec_trace.h:178,
from drivers/platform/chrome/cros_ec_trace.c:215:
drivers/platform/chrome/./cros_ec_trace.h:95:25: note: format string is defined here
95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
| ~~~~~^
| |
| long long int
| %12d
In file included from include/trace/define_trace.h:102,
from drivers/platform/chrome/cros_ec_trace.h:178,
from drivers/platform/chrome/cros_ec_trace.c:215:
drivers/platform/chrome/./cros_ec_trace.h:95:12: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'u32' {aka 'unsigned int'} [-Wformat=]
95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
399 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
80 | PARAMS(print)); \
| ^~~~~~
drivers/platform/chrome/./cros_ec_trace.h:74:1: note: in expansion of macro 'TRACE_EVENT'
74 | TRACE_EVENT(cros_ec_sensorhub_timestamp,
| ^~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:95:2: note: in expansion of macro 'TP_printk'
95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
| ^~~~~~~~~
In file included from include/trace/trace_events.h:433,
from include/trace/define_trace.h:102,
from drivers/platform/chrome/cros_ec_trace.h:178,
from drivers/platform/chrome/cros_ec_trace.c:215:
drivers/platform/chrome/./cros_ec_trace.h:95:45: note: format string is defined here
95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
| ~~~~~^
| |
| long long int
| %12d
In file included from include/trace/define_trace.h:102,
from drivers/platform/chrome/cros_ec_trace.h:178,
from drivers/platform/chrome/cros_ec_trace.c:215:
drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_sensorhub_data':
drivers/platform/chrome/./cros_ec_trace.h:125:12: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'u32' {aka 'unsigned int'} [-Wformat=]
125 | TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
399 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
80 | PARAMS(print)); \
| ^~~~~~
drivers/platform/chrome/./cros_ec_trace.h:105:1: note: in expansion of macro 'TRACE_EVENT'
105 | TRACE_EVENT(cros_ec_sensorhub_data,
| ^~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:125:2: note: in expansion of macro 'TP_printk'
125 | TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
| ^~~~~~~~~
In file included from include/trace/trace_events.h:433,
from include/trace/define_trace.h:102,
from drivers/platform/chrome/cros_ec_trace.h:178,
from drivers/platform/chrome/cros_ec_trace.c:215:
drivers/platform/chrome/./cros_ec_trace.h:125:43: note: format string is defined here
125 | TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
| ~~~~~^
| |
| long long int
| %12d
In file included from include/trace/define_trace.h:102,
from drivers/platform/chrome/cros_ec_trace.h:178,
from drivers/platform/chrome/cros_ec_trace.c:215:
drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_sensorhub_filter':
drivers/platform/chrome/./cros_ec_trace.h:156:12: warning: format '%d' expects argument of type 'int', but argument 7 has type 's64' {aka 'long long int'} [-Wformat=]
156 | TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
399 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
80 | PARAMS(print)); \
| ^~~~~~
drivers/platform/chrome/./cros_ec_trace.h:135:1: note: in expansion of macro 'TRACE_EVENT'
135 | TRACE_EVENT(cros_ec_sensorhub_filter,
| ^~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:156:2: note: in expansion of macro 'TP_printk'
156 | TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
| ^~~~~~~~~
In file included from include/trace/trace_events.h:433,
from include/trace/define_trace.h:102,
from drivers/platform/chrome/cros_ec_trace.h:178,
from drivers/platform/chrome/cros_ec_trace.c:215:
drivers/platform/chrome/./cros_ec_trace.h:156:80: note: format string is defined here
156 | TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
| ~^
| |
| int
| %lld
Introduced by commit
d453ceb6549a ("platform/chrome: sensorhub: Add trace events for sample")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the chrome-platform tree
2021-08-23 5:21 linux-next: build warning after merge of the chrome-platform tree Stephen Rothwell
@ 2021-08-30 7:21 ` Stephen Rothwell
2021-08-31 0:17 ` Benson Leung
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2021-08-30 7:21 UTC (permalink / raw)
To: Benson Leung, Guenter Roeck, Enric Balletbo i Serra, Dmitry Torokhov
Cc: Gwendal Grignou, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 8996 bytes --]
Hi all,
On Mon, 23 Aug 2021 15:21:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the chrome-platform tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_sensorhub_timestamp':
> drivers/platform/chrome/./cros_ec_trace.h:95:12: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'u32' {aka 'unsigned int'} [-Wformat=]
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
> 399 | trace_event_printf(iter, print); \
> | ^~~~~
> include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
> 80 | PARAMS(print)); \
> | ^~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:74:1: note: in expansion of macro 'TRACE_EVENT'
> 74 | TRACE_EVENT(cros_ec_sensorhub_timestamp,
> | ^~~~~~~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:95:2: note: in expansion of macro 'TP_printk'
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~
> In file included from include/trace/trace_events.h:433,
> from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h:95:25: note: format string is defined here
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ~~~~~^
> | |
> | long long int
> | %12d
> In file included from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h:95:12: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'u32' {aka 'unsigned int'} [-Wformat=]
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
> 399 | trace_event_printf(iter, print); \
> | ^~~~~
> include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
> 80 | PARAMS(print)); \
> | ^~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:74:1: note: in expansion of macro 'TRACE_EVENT'
> 74 | TRACE_EVENT(cros_ec_sensorhub_timestamp,
> | ^~~~~~~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:95:2: note: in expansion of macro 'TP_printk'
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~
> In file included from include/trace/trace_events.h:433,
> from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h:95:45: note: format string is defined here
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ~~~~~^
> | |
> | long long int
> | %12d
> In file included from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_sensorhub_data':
> drivers/platform/chrome/./cros_ec_trace.h:125:12: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'u32' {aka 'unsigned int'} [-Wformat=]
> 125 | TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
> 399 | trace_event_printf(iter, print); \
> | ^~~~~
> include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
> 80 | PARAMS(print)); \
> | ^~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:105:1: note: in expansion of macro 'TRACE_EVENT'
> 105 | TRACE_EVENT(cros_ec_sensorhub_data,
> | ^~~~~~~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:125:2: note: in expansion of macro 'TP_printk'
> 125 | TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~
> In file included from include/trace/trace_events.h:433,
> from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h:125:43: note: format string is defined here
> 125 | TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ~~~~~^
> | |
> | long long int
> | %12d
> In file included from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_sensorhub_filter':
> drivers/platform/chrome/./cros_ec_trace.h:156:12: warning: format '%d' expects argument of type 'int', but argument 7 has type 's64' {aka 'long long int'} [-Wformat=]
> 156 | TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
> 399 | trace_event_printf(iter, print); \
> | ^~~~~
> include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
> 80 | PARAMS(print)); \
> | ^~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:135:1: note: in expansion of macro 'TRACE_EVENT'
> 135 | TRACE_EVENT(cros_ec_sensorhub_filter,
> | ^~~~~~~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:156:2: note: in expansion of macro 'TP_printk'
> 156 | TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
> | ^~~~~~~~~
> In file included from include/trace/trace_events.h:433,
> from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h:156:80: note: format string is defined here
> 156 | TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
> | ~^
> | |
> | int
> | %lld
>
> Introduced by commit
>
> d453ceb6549a ("platform/chrome: sensorhub: Add trace events for sample")
I am still seeing these warnings.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the chrome-platform tree
2021-08-30 7:21 ` Stephen Rothwell
@ 2021-08-31 0:17 ` Benson Leung
2021-08-31 0:32 ` Stephen Rothwell
0 siblings, 1 reply; 11+ messages in thread
From: Benson Leung @ 2021-08-31 0:17 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Guenter Roeck, Enric Balletbo i Serra, Dmitry Torokhov,
Gwendal Grignou, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
Hi Stephen,
On Mon, Aug 30, 2021 at 05:21:32PM +1000, Stephen Rothwell wrote:
> > Introduced by commit
> >
> > d453ceb6549a ("platform/chrome: sensorhub: Add trace events for sample")
>
> I am still seeing these warnings.
> --
> Cheers,
> Stephen Rothwell
I've just pushed this to chrome-platform's for-next:
5a51bdb0ae26 ("platform/chrome: cros_ec_trace: Fix format warnings")
This should fix those warnings. Sorry for the long delay.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the chrome-platform tree
2021-08-31 0:17 ` Benson Leung
@ 2021-08-31 0:32 ` Stephen Rothwell
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2021-08-31 0:32 UTC (permalink / raw)
To: Benson Leung
Cc: Stephen Rothwell, Guenter Roeck, Enric Balletbo i Serra,
Dmitry Torokhov, Gwendal Grignou, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
Hi Benson,
On Mon, 30 Aug 2021 17:17:45 -0700 Benson Leung <bleung@google.com> wrote:
>
> On Mon, Aug 30, 2021 at 05:21:32PM +1000, Stephen Rothwell wrote:
> > > Introduced by commit
> > >
> > > d453ceb6549a ("platform/chrome: sensorhub: Add trace events for sample")
> >
> > I am still seeing these warnings.
> > --
> > Cheers,
> > Stephen Rothwell
>
> I've just pushed this to chrome-platform's for-next:
> 5a51bdb0ae26 ("platform/chrome: cros_ec_trace: Fix format warnings")
>
> This should fix those warnings. Sorry for the long delay.
Thanks.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the chrome-platform tree
2022-05-18 3:23 ` Bagas Sanjaya
2022-05-18 3:39 ` Tzung-Bi Shih
@ 2022-05-18 4:24 ` Muhammad Usama Anjum
1 sibling, 0 replies; 11+ messages in thread
From: Muhammad Usama Anjum @ 2022-05-18 4:24 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: usama.anjum, Tzung-Bi Shih, Linux Kernel Mailing List,
Linux Next Mailing List, Stephen Rothwell, Guenter Roeck,
Benson Leung, Dmitry Torokhov
Thank you!
On 5/18/22 8:23 AM, Bagas Sanjaya wrote:
> On 5/17/22 20:09, Muhammad Usama Anjum wrote:
>> I've found these warnings in local build. But I'm unable to fix them.
>> Apparently, there doesn't seem any unexpected indentation. This kind of
>> same warnings have also appeared on some more files before this commit
>> without any reason.
>>
>
> Hi,
>
> I've figured out the fix on [1]. Please review.
>
> [1]: https://lore.kernel.org/linux-next/20220518031750.21923-2-bagasdotme@gmail.com/
>
--
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the chrome-platform tree
2022-05-18 3:23 ` Bagas Sanjaya
@ 2022-05-18 3:39 ` Tzung-Bi Shih
2022-05-18 4:24 ` Muhammad Usama Anjum
1 sibling, 0 replies; 11+ messages in thread
From: Tzung-Bi Shih @ 2022-05-18 3:39 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Muhammad Usama Anjum, Stephen Rothwell, Benson Leung,
Guenter Roeck, Dmitry Torokhov, Linux Kernel Mailing List,
Linux Next Mailing List
On Wed, May 18, 2022 at 10:23:28AM +0700, Bagas Sanjaya wrote:
> On 5/17/22 20:09, Muhammad Usama Anjum wrote:
> > I've found these warnings in local build. But I'm unable to fix them.
> > Apparently, there doesn't seem any unexpected indentation. This kind of
> > same warnings have also appeared on some more files before this commit
> > without any reason.
> >
>
> Hi,
>
> I've figured out the fix on [1]. Please review.
>
> [1]: https://lore.kernel.org/linux-next/20220518031750.21923-2-bagasdotme@gmail.com/
Thanks for figuring it out. I was also investigating on the issue but got no clues.
Reviewed on [1].
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the chrome-platform tree
2022-05-17 13:09 ` Muhammad Usama Anjum
@ 2022-05-18 3:23 ` Bagas Sanjaya
2022-05-18 3:39 ` Tzung-Bi Shih
2022-05-18 4:24 ` Muhammad Usama Anjum
0 siblings, 2 replies; 11+ messages in thread
From: Bagas Sanjaya @ 2022-05-18 3:23 UTC (permalink / raw)
To: Muhammad Usama Anjum, Stephen Rothwell, Benson Leung,
Guenter Roeck, Dmitry Torokhov
Cc: Tzung-Bi Shih, Linux Kernel Mailing List, Linux Next Mailing List
On 5/17/22 20:09, Muhammad Usama Anjum wrote:
> I've found these warnings in local build. But I'm unable to fix them.
> Apparently, there doesn't seem any unexpected indentation. This kind of
> same warnings have also appeared on some more files before this commit
> without any reason.
>
Hi,
I've figured out the fix on [1]. Please review.
[1]: https://lore.kernel.org/linux-next/20220518031750.21923-2-bagasdotme@gmail.com/
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the chrome-platform tree
2022-05-16 11:38 Stephen Rothwell
@ 2022-05-17 13:09 ` Muhammad Usama Anjum
2022-05-18 3:23 ` Bagas Sanjaya
0 siblings, 1 reply; 11+ messages in thread
From: Muhammad Usama Anjum @ 2022-05-17 13:09 UTC (permalink / raw)
To: Stephen Rothwell, Benson Leung, Guenter Roeck, Dmitry Torokhov
Cc: usama.anjum, Tzung-Bi Shih, Linux Kernel Mailing List,
Linux Next Mailing List
On 5/16/22 4:38 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the chrome-platform tree, today's linux-next build
> (htmldocs) produced this warning:
>
> Documentation/ABI/testing/sysfs-driver-chromeos-acpi:2: WARNING: Unexpected indentation.
> Documentation/ABI/testing/sysfs-driver-chromeos-acpi:11: WARNING: Unexpected indentation.
> Documentation/ABI/testing/sysfs-driver-chromeos-acpi:22: WARNING: Unexpected indentation.
> Documentation/ABI/testing/sysfs-driver-chromeos-acpi:56: WARNING: Unexpected indentation.
>
> Introduced by commit
>
> 0a4cad9c11ad ("platform/chrome: Add ChromeOS ACPI device driver")
>
I've found these warnings in local build. But I'm unable to fix them.
Apparently, there doesn't seem any unexpected indentation. This kind of
same warnings have also appeared on some more files before this commit
without any reason.
--
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the chrome-platform tree
@ 2022-05-16 11:38 Stephen Rothwell
2022-05-17 13:09 ` Muhammad Usama Anjum
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2022-05-16 11:38 UTC (permalink / raw)
To: Benson Leung, Guenter Roeck, Dmitry Torokhov
Cc: Enric Balletbo i Serra, Muhammad Usama Anjum, Tzung-Bi Shih,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
Hi all,
After merging the chrome-platform tree, today's linux-next build
(htmldocs) produced this warning:
Documentation/ABI/testing/sysfs-driver-chromeos-acpi:2: WARNING: Unexpected indentation.
Documentation/ABI/testing/sysfs-driver-chromeos-acpi:11: WARNING: Unexpected indentation.
Documentation/ABI/testing/sysfs-driver-chromeos-acpi:22: WARNING: Unexpected indentation.
Documentation/ABI/testing/sysfs-driver-chromeos-acpi:56: WARNING: Unexpected indentation.
Introduced by commit
0a4cad9c11ad ("platform/chrome: Add ChromeOS ACPI device driver")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the chrome-platform tree
2019-04-16 4:30 Stephen Rothwell
@ 2019-04-16 9:09 ` Enric Balletbo i Serra
0 siblings, 0 replies; 11+ messages in thread
From: Enric Balletbo i Serra @ 2019-04-16 9:09 UTC (permalink / raw)
To: Stephen Rothwell, Benson Leung, Guenter Roeck, Dmitry Torokhov
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Nick Crews
On 16/4/19 6:30, Stephen Rothwell wrote:
> Hi all,
>
> After merging the chrome-platform tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from drivers/platform/chrome/wilco_ec/debugfs.c:11:
> drivers/platform/chrome/wilco_ec/debugfs.c: In function 'fops_h1_gpio_open':
> drivers/platform/chrome/wilco_ec/debugfs.c:210:59: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long long unsigned int' [-Wformat=]
> DEFINE_DEBUGFS_ATTRIBUTE(fops_h1_gpio, h1_gpio_get, NULL, "0x%02x\n");
> ^~~~~~~~~~
> include/linux/debugfs.h:45:29: note: in definition of macro 'DEFINE_DEBUGFS_ATTRIBUTE'
> __simple_attr_check_format(__fmt, 0ull); \
> ^~~~~
>
> Introduced by commit
>
> db6c540a0018 ("platform/chrome: wilco_ec: Add h1_gpio status to debugfs")
>
Fixed, I need to automate my builders a bit more to catch these things. Sorry
for the noise. Thanks.
Enric
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the chrome-platform tree
@ 2019-04-16 4:30 Stephen Rothwell
2019-04-16 9:09 ` Enric Balletbo i Serra
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2019-04-16 4:30 UTC (permalink / raw)
To: Benson Leung, Guenter Roeck, Enric Balletbo i Serra, Dmitry Torokhov
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Nick Crews
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
Hi all,
After merging the chrome-platform tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from drivers/platform/chrome/wilco_ec/debugfs.c:11:
drivers/platform/chrome/wilco_ec/debugfs.c: In function 'fops_h1_gpio_open':
drivers/platform/chrome/wilco_ec/debugfs.c:210:59: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long long unsigned int' [-Wformat=]
DEFINE_DEBUGFS_ATTRIBUTE(fops_h1_gpio, h1_gpio_get, NULL, "0x%02x\n");
^~~~~~~~~~
include/linux/debugfs.h:45:29: note: in definition of macro 'DEFINE_DEBUGFS_ATTRIBUTE'
__simple_attr_check_format(__fmt, 0ull); \
^~~~~
Introduced by commit
db6c540a0018 ("platform/chrome: wilco_ec: Add h1_gpio status to debugfs")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-05-18 4:24 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 5:21 linux-next: build warning after merge of the chrome-platform tree Stephen Rothwell
2021-08-30 7:21 ` Stephen Rothwell
2021-08-31 0:17 ` Benson Leung
2021-08-31 0:32 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2022-05-16 11:38 Stephen Rothwell
2022-05-17 13:09 ` Muhammad Usama Anjum
2022-05-18 3:23 ` Bagas Sanjaya
2022-05-18 3:39 ` Tzung-Bi Shih
2022-05-18 4:24 ` Muhammad Usama Anjum
2019-04-16 4:30 Stephen Rothwell
2019-04-16 9:09 ` Enric Balletbo i Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).