From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD91AC4320E for ; Tue, 31 Aug 2021 00:53:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A75556101B for ; Tue, 31 Aug 2021 00:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239241AbhHaAyp (ORCPT ); Mon, 30 Aug 2021 20:54:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:53190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231989AbhHaAyn (ORCPT ); Mon, 30 Aug 2021 20:54:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E499A60FF2; Tue, 31 Aug 2021 00:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630371229; bh=wBfoW5VjwX94tcmf1r6pB9v16U5JrskEzJHYSKjraeA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kbsDjgF4iL4PUIHG0HoCvJiey/CrxhSgz64wChmx8LYG+bVhTon7os6IsuNZirvRz YandMPLGIx9SEZvQL8C3AzBJVVCiU/L8U6TSzGZ0LDiiVzWtfcg33ExaBw3MqTRmtn NJP2a8hktUNxs72et2K904CfeaJHLfmcUWrPbg61rMZoG5P0AwK1aU1HN2ALtL5bWp 3fVG20HP+dmaezpLzyvEPZOLDLGmFqXr+4R7uWpidqfDfbOMb3nTGy1lGl8zLt28/9 HX6FPUpdG9SfMCYPznYdh6K8UoebkRyxldHQRHphVsepPRNcYHlPeDcU1KFc4ZYm7v 2MbMVD4/RTmrA== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH 2/2] f2fs: should put a page beyond EOF when preparing a write Date: Mon, 30 Aug 2021 17:53:46 -0700 Message-Id: <20210831005346.118701-2-jaegeuk@kernel.org> X-Mailer: git-send-email 2.33.0.259.gc128427fd7-goog In-Reply-To: <20210831005346.118701-1-jaegeuk@kernel.org> References: <20210831005346.118701-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The prepare_compress_overwrite() gets/locks a page to prepare a read, and calls f2fs_read_multi_pages() which checks EOF first. If there's any page beyond EOF, we unlock the page and set cc->rpages[i] = NULL, which we can't put the page anymore. This makes page leak, so let's fix by putting that page. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 8e8824605f83..41d29382eced 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2183,6 +2183,8 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret, continue; } unlock_page(page); + if (for_write) + put_page(page); cc->rpages[i] = NULL; cc->nr_rpages--; } -- 2.33.0.259.gc128427fd7-goog