From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB74C4320A for ; Tue, 31 Aug 2021 17:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECF176101B for ; Tue, 31 Aug 2021 17:30:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240290AbhHaRbY (ORCPT ); Tue, 31 Aug 2021 13:31:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233345AbhHaRbX (ORCPT ); Tue, 31 Aug 2021 13:31:23 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E603C061575 for ; Tue, 31 Aug 2021 10:30:28 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id d3-20020a17090ae28300b0019629c96f25so23213pjz.2 for ; Tue, 31 Aug 2021 10:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RR58B/xYGJafxin5HeHSX4dLzWc56hmmhBLa05Y8cXM=; b=AbxW1+lW0iR9IecIcWmDkhs34/VdSO4avGg/BAMtpRoucC0VTQ+bku0ZpnWNCtdKKd s04U+9eOwwvYZUIT5xLheScJ37r88IsGEBmXVifrWhSlfnwu7wRjEOv2nS97FgdFwNca WWTsln9Gem/D1y8mj8uSkF/n1DgfvLwBwDnfE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RR58B/xYGJafxin5HeHSX4dLzWc56hmmhBLa05Y8cXM=; b=qVVr3ROEzEbewFQVJBJrbiBybDk+milww4k2f+86XOdDvAYOtk9PsOEbN/m0sanGTh fHa9kJGbHkZqdkgZpEE+pBOudrjbHVxxVMb+sum7OK0Ubz16/TFDyAdLurrfL2LREeJ3 EzYpE5o2bcC73S+MFpPZoGs//fj9ztXNr56wi5iuCAjbsDlY9Lwec59BjZWuJONrMagj 0In2uCd30s9SEkFalFmRXOd7SfQxFdtt3QUep5YtAQwuzv5IR8paLsYjA54VHqndD27l YYh/MVfEv8AF7Nun30pgr3yzoh0veIxK67Bw/tyGID22DPuVeN6gC8fqmCuQPOY8Lu8q aQMQ== X-Gm-Message-State: AOAM533cJyjP5fgPmPT7a1ojoe6kqjKFs6g/zNdKQfG+4gBnbNfckkr0 KZ2sxy8JNysF43dweockR4yV1g== X-Google-Smtp-Source: ABdhPJzn2E3XqZObb7PyG8evez59tKrv/PLIVSkTIsUT6DkRP7iTI6Mib+vjLKFL2rm1r/lNLENCFQ== X-Received: by 2002:a17:902:b093:b029:12c:843:b55a with SMTP id p19-20020a170902b093b029012c0843b55amr5725338plr.83.1630431027801; Tue, 31 Aug 2021 10:30:27 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q3sm21692389pgf.18.2021.08.31.10.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 10:30:26 -0700 (PDT) Date: Tue, 31 Aug 2021 10:30:25 -0700 From: Kees Cook To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Michal Marek , Nick Desaulniers , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/13] kbuild: store the objtool command in *.cmd files Message-ID: <202108311030.41739E4@keescook> References: <20210831074004.3195284-1-masahiroy@kernel.org> <20210831074004.3195284-4-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210831074004.3195284-4-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 31, 2021 at 04:39:54PM +0900, Masahiro Yamada wrote: > objtool_dep includes include/config/{ORC_UNWINDER,STACK_VALIDATION} > so that all the objects are rebuilt when any of CONFIG_ORC_UNWINDER > and CONFIG_STACK_VALIDATION is toggled. > > As you can see in 'objtool_args', there are more CONFIG options > that affect the objtool command line. > > Adding more and more include/config/* is ugly and unmaintainable. > > Another issue is that non-standard objects are needlessly rebuilt. > Objects specified as OBJECT_FILES_NON_STANDARD is not processed by > objtool, but they are rebuilt anyway when CONFIG_ORC_UNWINDER or > CONFIG_STACK_VALIDATION is toggled. This is not a big deal, but > better to fix. > > A cleaner and more precise fix is to include the objtool command in > *.cmd files so any command change is naturally detected by if_change. > > Signed-off-by: Masahiro Yamada Yeah, nice solution for this. Reviewed-by: Kees Cook -- Kees Cook