* [PATCH] media: s5p-jpeg: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-01 5:56 Cai Huoqing
2021-09-01 9:18 ` Andrzej Pietrasiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2021-09-01 5:56 UTC (permalink / raw)
To: caihuoqing
Cc: Andrzej Pietrasiewicz, Jacek Anaszewski, Sylwester Nawrocki,
Mauro Carvalho Chehab, linux-arm-kernel, linux-media,
linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
index d402e456f27d..1faff037cdf7 100644
--- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
+++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
@@ -2850,7 +2850,6 @@ static void *jpeg_get_drv_data(struct device *dev);
static int s5p_jpeg_probe(struct platform_device *pdev)
{
struct s5p_jpeg *jpeg;
- struct resource *res;
int i, ret;
/* JPEG IP abstraction struct */
@@ -2867,9 +2866,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev)
jpeg->dev = &pdev->dev;
/* memory-mapped registers */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
- jpeg->regs = devm_ioremap_resource(&pdev->dev, res);
+ jpeg->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(jpeg->regs))
return PTR_ERR(jpeg->regs);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: s5p-jpeg: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 5:56 [PATCH] media: s5p-jpeg: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-01 9:18 ` Andrzej Pietrasiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Pietrasiewicz @ 2021-09-01 9:18 UTC (permalink / raw)
To: Cai Huoqing
Cc: Jacek Anaszewski, Sylwester Nawrocki, Mauro Carvalho Chehab,
linux-arm-kernel, linux-media, linux-kernel
Hi Cai Huoqing,
Thank you for the patch.
W dniu 01.09.2021 o 07:56, Cai Huoqing pisze:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
> ---
> drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> index d402e456f27d..1faff037cdf7 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> @@ -2850,7 +2850,6 @@ static void *jpeg_get_drv_data(struct device *dev);
> static int s5p_jpeg_probe(struct platform_device *pdev)
> {
> struct s5p_jpeg *jpeg;
> - struct resource *res;
> int i, ret;
>
> /* JPEG IP abstraction struct */
> @@ -2867,9 +2866,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev)
> jpeg->dev = &pdev->dev;
>
> /* memory-mapped registers */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> - jpeg->regs = devm_ioremap_resource(&pdev->dev, res);
> + jpeg->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(jpeg->regs))
> return PTR_ERR(jpeg->regs);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-01 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 5:56 [PATCH] media: s5p-jpeg: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 9:18 ` Andrzej Pietrasiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).