linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org,
	"Steven Rostedt (VMware)" <rostedt@goodmis.org>
Subject: Re: [kbuild] [trace:ftrace/core 35/39] kernel/trace/trace_boot.c:420 trace_boot_init_histograms() warn: curly braces intended?
Date: Wed, 1 Sep 2021 11:07:13 +0900	[thread overview]
Message-ID: <20210901110713.fed0ebd23c05033045953642@kernel.org> (raw)
In-Reply-To: <202109010207.nUISBZUN-lkp@intel.com>

Hi Dan,

On Tue, 31 Aug 2021 21:45:11 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git  ftrace/core
> head:   3dc65994e3c1c999be3d991cdc96705e167cb3b1
> commit: 5d4648a0415efc239ffb377bce1d389723eda25d [35/39] tracing/boot: Show correct histogram error command
> config: x86_64-randconfig-m001-20210831 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> smatch warnings:
> kernel/trace/trace_boot.c:420 trace_boot_init_histograms() warn: curly braces intended?
> kernel/trace/trace_boot.c:421 trace_boot_init_histograms() error: uninitialized symbol 'tmp'.
> kernel/trace/trace_boot.c:421 trace_boot_init_histograms() warn: passing freed memory 'tmp'
> kernel/trace/trace_boot.c:422 trace_boot_init_histograms() error: double free of 'tmp'
> 
> vim +420 kernel/trace/trace_boot.c
> 
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  396  static void __init
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  397  trace_boot_init_histograms(struct trace_event_file *file,
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  398  			   struct xbc_node *hnode, char *buf, size_t size)
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  399  {
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  400  	struct xbc_node *node;
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  401  	const char *p;
> 5d4648a0415efc2 Masami Hiramatsu 2021-08-06  402  	char *tmp;
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  403  
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  404  	xbc_node_for_each_subkey(hnode, node) {
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  405  		p = xbc_node_get_data(node);
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  406  		if (!isdigit(p[0]))
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  407  			continue;
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  408  		/* All digit started node should be instances. */
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  409  		if (trace_boot_compose_hist_cmd(node, buf, size) == 0) {
> 5d4648a0415efc2 Masami Hiramatsu 2021-08-06  410  			tmp = kstrdup(buf, GFP_KERNEL);
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  411  			if (trigger_process_regex(file, buf) < 0)
> 5d4648a0415efc2 Masami Hiramatsu 2021-08-06  412  				pr_err("Failed to apply hist trigger: %s\n", tmp);
> 5d4648a0415efc2 Masami Hiramatsu 2021-08-06  413  			kfree(tmp);
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  414  		}
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  415  	}
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  416  
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  417  	if (xbc_node_find_child(hnode, "keys")) {
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  418  		if (trace_boot_compose_hist_cmd(hnode, buf, size) == 0)
> 
> The missing curly braces here trigger a ball of static checker warnings.
> I'm so happy about that.  :)

The ftrace/core branch has a wrong version of the patch. ftrae/for-next has
correct one. I think Steve correct this mismatch after he comes back.

Thank you,



> 
> 5d4648a0415efc2 Masami Hiramatsu 2021-08-06  419  			tmp = kstrdup(buf, GFP_KERNEL);
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06 @420  			if (trigger_process_regex(file, buf) < 0)
> 5d4648a0415efc2 Masami Hiramatsu 2021-08-06 @421  				pr_err("Failed to apply hist trigger: %s\n", tmp);
> 5d4648a0415efc2 Masami Hiramatsu 2021-08-06 @422  			kfree(tmp);
> 30cb856e3067e5d Masami Hiramatsu 2021-08-06  423  	}
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org 
> 
> _______________________________________________
> kbuild mailing list -- kbuild@lists.01.org
> To unsubscribe send an email to kbuild-leave@lists.01.org
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

  reply	other threads:[~2021-09-01  2:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 18:45 [kbuild] [trace:ftrace/core 35/39] kernel/trace/trace_boot.c:420 trace_boot_init_histograms() warn: curly braces intended? Dan Carpenter
2021-09-01  2:07 ` Masami Hiramatsu [this message]
2021-09-03 20:41   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210901110713.fed0ebd23c05033045953642@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).