From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A057C432BE for ; Thu, 2 Sep 2021 10:54:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 429BA60F91 for ; Thu, 2 Sep 2021 10:54:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233708AbhIBKzU (ORCPT ); Thu, 2 Sep 2021 06:55:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:39238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231133AbhIBKzT (ORCPT ); Thu, 2 Sep 2021 06:55:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C968C60F91; Thu, 2 Sep 2021 10:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630580060; bh=q0GNvNblP6lxsGan6KTY29HU10SRkr+7SoHSRmhQuD8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tU5zJblbO0vmpIY7OfTkrTXk4AzIk6NN/0g6+WOd6GtrHSpfu7XUvVy6IPpdoOOXG 8ahHHMv/HlC78ooogIA/xsH9yPZHV+Uy/Upzp1NFGHqeOVU43yJypQWlnX/GkZB6d5 7kgroJp8X9yktEckGusw3lQ5AsTGacD0YsFEqE1NQ6YHnSc5wi7YQT8XIutobc5emL e3znvaZsXOce/ZEbYNJbLreX1u8Vze9AEYWvA/JOW+Xnc/oUh4tc6rkMiia6ZP5I89 WNCdqi9eyJWRgaBnVXeMAsLnbhjMmQhoLWmCBV0ZYGx4ZtBvgSBybXlbI93l9Zqyr0 4faQ3kVMnHaBw== Date: Thu, 2 Sep 2021 12:54:16 +0200 From: Mauro Carvalho Chehab To: Greg KH Cc: Dongliang Mu , linux-media@vger.kernel.org, linux-kernel , Dan Carpenter Subject: Re: [PATCH] media: usb: fix memory leak in stk_camera_probe Message-ID: <20210902125416.1ad73fad@coco.lan> In-Reply-To: References: <20210714032340.504836-1-mudongliangabcd@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, 2 Sep 2021 12:39:37 +0200 Greg KH escreveu: > On Thu, Sep 02, 2021 at 06:23:36PM +0800, Dongliang Mu wrote: > > On Fri, Jul 23, 2021 at 6:11 PM Dongliang Mu wrote: > > > > > > On Wed, Jul 14, 2021 at 11:23 AM Dongliang Mu wrote: > > > > > > > > stk_camera_probe mistakenly execute usb_get_intf and increase the > > > > refcount of interface->dev. > > > > > > > > Fix this by removing the execution of usb_get_intf. > > > > > > Any idea about this patch? > > > > +cc Dan Carpenter, gregkh > > > > There is no reply in this thread in one month. Can someone give some > > feedback on this patch? > > This is the media developers domain, not much I can do here. There is a high volume of patches for the media subsystem. Anyway, as your patch is at our patchwork instance: https://patchwork.linuxtv.org/project/linux-media/patch/20210714032340.504836-1-mudongliangabcd@gmail.com/ It should be properly tracked, and likely handled after the end of the merge window. > > > > Reported-by: Dongliang Mu > > > > Fixes: 0aa77f6c2954 ("[media] move the remaining USB drivers to drivers/media/usb") > > > > Signed-off-by: Dongliang Mu If you're the author of the patch, it doesn't make much sense to add a "Reported-by:" tag there. We only use it in order to give someone's else credit to report an issue. Thanks, Mauro