From: Jean Delvare <jdelvare@suse.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Kai-Chuan Hsieh <kaichuan.hsieh@canonical.com>,
Erwan Velu <e.velu@criteo.com>
Subject: Re: [PATCH regression fix] firmware/dmi: Move product_sku info to the end of the modalias
Date: Thu, 2 Sep 2021 19:07:39 +0200 [thread overview]
Message-ID: <20210902190739.686eb8b1@endymion> (raw)
In-Reply-To: <20210831130508.14511-1-hdegoede@redhat.com>
Hi Hans,
On Tue, 31 Aug 2021 15:05:08 +0200, Hans de Goede wrote:
> Commit e26f023e01ef ("firmware/dmi: Include product_sku info to modalias")
> added a new field to the modalias in the middle of the modalias, breaking
> some existing udev/hwdb matches on the whole modalias without a wildcard
> ('*') in between the pvr and rvn fields.
>
> All modalias matches in e.g. :
> https://github.com/systemd/systemd/blob/main/hwdb.d/60-sensor.hwdb
> deliberately end in ':*' so that new fields can be added at *the end* of
> the modalias, but adding a new field in the middle like this breaks things.
>
> Move the new sku field to the end of the modalias to fix some hwdb
> entries no longer matching.
Argh. Sorry for missing that, and thanks a lot for spotting it,
reporting it and providing a fix. I never liked the modalias format as
it makes matches clearly fragile. I really need to keep this in mind
when touching it.
Patch applied and pushed to linux-next. I'll send it to Linus for
5.14.1 quickly too.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2021-09-02 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 13:05 [PATCH regression fix] firmware/dmi: Move product_sku info to the end of the modalias Hans de Goede
2021-08-31 14:20 ` Hans de Goede
2021-09-02 17:07 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902190739.686eb8b1@endymion \
--to=jdelvare@suse.de \
--cc=e.velu@criteo.com \
--cc=hdegoede@redhat.com \
--cc=kaichuan.hsieh@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).