From: kernel test robot <lkp@intel.com>
To: Zijun Hu <zijuhu@codeaurora.org>,
marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bgodavar@codeaurora.org, c-hbandi@codeaurora.org,
hemantg@codeaurora.org, mka@chromium.org
Subject: Re: [PATCH v7] Bluetooth: btusb: Add support using different nvm for variant WCN6855 controller
Date: Thu, 2 Sep 2021 22:36:28 +0800 [thread overview]
Message-ID: <202109022228.thsn6Ujc-lkp@intel.com> (raw)
In-Reply-To: <1630572986-30786-1-git-send-email-zijuhu@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 3557 bytes --]
Hi Zijun,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on linus/master v5.14 next-20210902]
[cannot apply to linux/master bluetooth/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zijun-Hu/Bluetooth-btusb-Add-support-using-different-nvm-for-variant-WCN6855-controller/20210902-165857
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: i386-randconfig-s002-20210831 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-348-gf0e6938b-dirty
# https://github.com/0day-ci/linux/commit/971383be35e3681a6e8b1e85ad3c01f21f4e0076
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zijun-Hu/Bluetooth-btusb-Add-support-using-different-nvm-for-variant-WCN6855-controller/20210902-165857
git checkout 971383be35e3681a6e8b1e85ad3c01f21f4e0076
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/bluetooth/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/bluetooth/btusb.c:1871:18: sparse: sparse: cast to restricted __le16
drivers/bluetooth/btusb.c:1875:18: sparse: sparse: cast to restricted __le16
drivers/bluetooth/btusb.c:1879:18: sparse: sparse: cast to restricted __le16
drivers/bluetooth/btusb.c:1883:18: sparse: sparse: cast to restricted __le16
drivers/bluetooth/btusb.c:1887:18: sparse: sparse: cast to restricted __le16
drivers/bluetooth/btusb.c:1893:18: sparse: sparse: cast to restricted __le16
drivers/bluetooth/btusb.c:3330:28: sparse: sparse: cast to restricted __le32
drivers/bluetooth/btusb.c:3362:18: sparse: sparse: restricted __le16 degrades to integer
>> drivers/bluetooth/btusb.c:3386:20: sparse: sparse: restricted __le32 degrades to integer
>> drivers/bluetooth/btusb.c:3386:20: sparse: sparse: restricted __le32 degrades to integer
vim +3386 drivers/bluetooth/btusb.c
3377
3378 static int btusb_setup_qca_load_nvm(struct hci_dev *hdev,
3379 struct qca_version *ver,
3380 const struct qca_device_info *info)
3381 {
3382 const struct firmware *fw;
3383 char fwname[64];
3384 int err;
3385
> 3386 switch (ver->ram_version) {
3387 case WCN6855_2_0_RAM_VERSION_GF:
3388 case WCN6855_2_1_RAM_VERSION_GF:
3389 btusb_generate_qca_nvm_name(fwname, sizeof(fwname), ver, "gf");
3390 break;
3391 default:
3392 btusb_generate_qca_nvm_name(fwname, sizeof(fwname), ver, "");
3393 break;
3394 }
3395
3396 err = request_firmware(&fw, fwname, &hdev->dev);
3397 if (err) {
3398 bt_dev_err(hdev, "failed to request NVM file: %s (%d)",
3399 fwname, err);
3400 return err;
3401 }
3402
3403 bt_dev_info(hdev, "using NVM file: %s", fwname);
3404
3405 err = btusb_setup_qca_download_fw(hdev, fw, info->nvm_hdr);
3406
3407 release_firmware(fw);
3408
3409 return err;
3410 }
3411
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36231 bytes --]
next prev parent reply other threads:[~2021-09-02 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 8:56 [PATCH v7] Bluetooth: btusb: Add support using different nvm for variant WCN6855 controller Zijun Hu
2021-09-02 9:41 ` Marcel Holtmann
2021-09-02 14:36 ` kernel test robot [this message]
2021-09-02 17:46 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109022228.thsn6Ujc-lkp@intel.com \
--to=lkp@intel.com \
--cc=bgodavar@codeaurora.org \
--cc=c-hbandi@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=zijuhu@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).