From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF8D9C433EF for ; Fri, 3 Sep 2021 09:21:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5006603E7 for ; Fri, 3 Sep 2021 09:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348766AbhICJWU (ORCPT ); Fri, 3 Sep 2021 05:22:20 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:40233 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348762AbhICJWM (ORCPT ); Fri, 3 Sep 2021 05:22:12 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 837B832001FC; Fri, 3 Sep 2021 05:21:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 03 Sep 2021 05:21:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=sAiRI9c4Qga0Ic/pFIIogIPRDm5 9Php5SKSojiIRi2M=; b=GTITGcZfwHPhKcJ0YbdWs+77drjMuX+GOGL/caWx0CQ LB0rx8Qo49Jb6V7r3QtF+DQ1HGPLSvWwriYNZT6kSA/stV0+c5XPJ7yk6YlSiICf LryluppuuYWbEEgfj2EVVLIMOV2U2XnGMZwz9Ux6JAqZyHYmlCkva5m49WnVmpwr VB6o20E5zk11oyxgS4ylIglxqN+XhlRqxxjmi714oEqj2Z40tpuPva2zQOqYqxDj GP8KyX0Dv96gptg7gANyGehoh1jvQKptRbOuH0t/xs4DErGgFfo8fW2sRZIcomcK qnqgrJ0soGcLfr9QLrFycCfaQXpcE5PxUMvADqF/CiA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=sAiRI9 c4Qga0Ic/pFIIogIPRDm59Php5SKSojiIRi2M=; b=lq56pGPZ44bjRLjn9OsJk3 BZ1v41iIcfR//FNYxbI0Yw41yMTaJIlGok4nnJe+dQyph84JV1eioAsQEF2lYVvz Q9j3ivCrhD31E3w9uHebBgbPwo18varz7sfXgIYSXMpAarIxqzN1itRHM1PhBOA3 2qiDwlL/4p1O6TO6cplD9k/PRw+2dKx0xKr8j/gpK38qO4rKuiZNlzgiN6e5DX6k qSuZfeiWYy5FiMbq1jgs6Wam605LpmTnkh14GFNC5uqQlqFB0AljNit3x+0DIqyC MwEXmGu7F2o2gPlU/foOFqM+4wGOVro7BR2Mx1/HKVKGx33mOVwjHrsUx+fDgmuw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddvjedgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepuedtgfejueduheevgfevvdettdduleffgfffkeeltdffkeegudekjeeuveei gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Sep 2021 05:21:09 -0400 (EDT) Date: Fri, 3 Sep 2021 11:21:08 +0200 From: Maxime Ripard To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Andrew Lunn , Chen-Yu Tsai , =?utf-8?B?Q2zDqW1lbnQgQsWTc2No?= , Willy Liu , Rob Herring , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Message-ID: <20210903092108.62oqmqveze7usrgk@gilmour> References: <20210830151645.18018-1-u@pkh.me> <1746741.3t3T1tWQfl@kista> <6939430.QNQgkB6KyE@kista> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2mnkm2zv2dbvyw5v" Content-Disposition: inline In-Reply-To: <6939430.QNQgkB6KyE@kista> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2mnkm2zv2dbvyw5v Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2021 at 05:31:32PM +0200, Jernej =C5=A0krabec wrote: > Dne torek, 31. avgust 2021 ob 22:53:24 CEST je Andrew Lunn napisal(a): > > > True, but then again, DT is a bit special, since it's not used only b= y=20 > Linux.=20 > > > It's shared at least with BSDs and U-Boot, which most likely have=20 > independent=20 > > > driver implementation. That's why it's good to have DT fixes referenc= ing DT=20 > > > related commits. As you said, DT described HW wrong. > > >=20 > > > Looking at past Allwinner related DT commits regarding this issue, we= were=20 > not=20 > > > totally consistent. Most of them reference commit where emac node was= =20 > > > introduced in DT. But I also found a couple of commits which indeed h= ave=20 > fixes=20 > > > tag for bbc4d71d6354. > >=20 > > All true, and it is not a big deal if it does go back further. I don't > > care, we can let the Allwinner Maintainer decide. Ah, that is you :-) > >=20 > > I just want to try to keep it simple for somebody who is contributing > > their first Linux kernel patch. If it is good enough, i say accept it, > > and we can do a bit more education on the second contribution. >=20 > Maxime, Chen-Yu, thoughts? >=20 > Since there are both approaches for fixes tag already in, I guess this is= also=20 > fine. I agree with you, the fixes should point at the initial Device Tree issue. Our DT are used by other projects and even if in Linux it wasn't causing any issue before another commit showed up, it might affect those projects differently. Maxime --2mnkm2zv2dbvyw5v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYTHpBAAKCRDj7w1vZxhR xe77AQDS7w4amoRbxd9sNcrSODsRJ0/4gRAAoPBh7Z+Q+gDAmAEA1dXNXw9B74Bm jH0v9R+BTKJ7wCf+9NtwDGhFFLrbCQg= =qQ3P -----END PGP SIGNATURE----- --2mnkm2zv2dbvyw5v--