From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A05F8C4332F for ; Fri, 3 Sep 2021 10:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C55F60F42 for ; Fri, 3 Sep 2021 10:19:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349072AbhICKUN (ORCPT ); Fri, 3 Sep 2021 06:20:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:56468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234262AbhICKUK (ORCPT ); Fri, 3 Sep 2021 06:20:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ECD8260F42; Fri, 3 Sep 2021 10:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630664350; bh=6luTq7e/gR3qVGMTHfn1KXrVL40WQTwM4lI/qO5d+jk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QnTB8MelMxrhCFXOp7WPxdaQLoaENJdHsrsL4B2CC/5WPsrAFh2kW7K9MtCw2bx19 AqlMGSCaszXExdVO3LK3+UQ+20csKffzazNuDtJlJb3X8p7VrpqkntEHNDWwk1Biiu H07zwKBuQTC57DvjSTl0uVeNzzes2bInEwMgsYw9GBFeVDvPd8JJUnma8CUEmIBfPk 6Yx4mn+AM3012u+Sci8P/43h7pchd5SzCL9oqwIsJo3/gxBUSTaNCnvaa33zitLz3K gyEKDqlbkZqn/fgdnxU2X5W+RTlSGj6IRiZ/8bkP9Qs7LQ26vmfvgMDytmh6pzOwEz SoKZLGQTga4cw== Date: Fri, 3 Sep 2021 11:18:37 +0100 From: Mark Brown To: Parshuram Raju Thombare Cc: "lukas@wunner.de" , "p.yadav@ti.com" , "robh+dt@kernel.org" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jayshri Dajiram Pawar , Milind Parab , Konrad Kociolek Subject: Re: [PATCH v3 2/2] spi: cadence: add support for Cadence XSPI controller Message-ID: <20210903101837.GA4932@sirena.org.uk> References: <1630499755-18751-1-git-send-email-pthombar@cadence.com> <1630499858-20456-1-git-send-email-pthombar@cadence.com> <20210902143947.GC11164@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline In-Reply-To: X-Cookie: Darth Vader sleeps with a Teddywookie. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 03, 2021 at 08:10:38AM +0000, Parshuram Raju Thombare wrote: > >> + master->mode_bits = SPI_3WIRE | SPI_TX_DUAL | SPI_TX_QUAD | > >> + SPI_RX_DUAL | SPI_RX_QUAD | SPI_TX_OCTAL | SPI_RX_OCTAL > >| > >> + SPI_MODE_0 | SPI_MODE_3; > >I don't see any handling of these in the code? > This is just to declare controller's capability, so that spi_setup() can modify > spi->mode according to the capability of attached device. In order for this to work I would expect there to be code in the driver which configures the controller into the specified mode. --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEx9nwACgkQJNaLcl1U h9ANwwf9GQT/fFI93cvXG99OAiBBenPxeG+GJqck6BoH5Ybw5wEoFCM1XIm/uvDd pflf/NXz2OpVFsH/4UhqKDayAOa/6iytSIzvfojXRrsVF/CA05SdKoWZUT00ClNw PSe/CgeSNXTj6cY3C3t0/paEY/TCNGKw5HuA5HUm8xyMB/6/3WFXzC2SOyVmeqVS zl0xCXvVFtO828RaGd5hREtBRI+LSoD8MdCoXetHNJwpoTGiEoHjBDlfBJLw5NIB 4gZctwspMZ3ZXzp8lFinMFRcZlsgENiXaHfbAA0CUQEHpbUPSCUeRNTXix5PE/PQ uavf3AV7X9gamPcvHBiYfqzJy0ybsQ== =yecK -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR--