From: Kees Cook <keescook@chromium.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Daniel Vetter <daniel@ffwll.ch>,
Dan Williams <dan.j.williams@intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Keith Packard <keithp@keithp.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-hardening@vger.kernel.org
Subject: Re: [GIT PULL] overflow updates for v5.15-rc1
Date: Sun, 5 Sep 2021 13:52:29 -0700 [thread overview]
Message-ID: <202109051257.29B29745C0@keescook> (raw)
In-Reply-To: <CAHk-=widUkzjVMW99L6OZpJc1wDnZbBbnOOzgXOMypOPoV6mjg@mail.gmail.com>
On Sun, Sep 05, 2021 at 10:36:22AM -0700, Linus Torvalds wrote:
> This is actually just bog-standard gcc-11.2 from F34, and an allmodconfig build.
I've checked this on F32 now, and I still wasn't seeing the testsuite
warnings. I did see this, though, unrelated to (but certainly thematically
associated with) the overflow series:
fs/qnx4/dir.c: In function 'qnx4_readdir':
fs/qnx4/dir.c:51:32: warning: 'strnlen' specified bound 48 exceeds source size 16 [-Wstringop-overread]
51 | size = strnlen(de->di_fname, size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from fs/qnx4/qnx4.h:3,
from fs/qnx4/dir.c:16:
./include/uapi/linux/qnx4_fs.h:45:25: note: source object declared here
45 | char di_fname[QNX4_SHORT_NAME_MAX];
| ^~~~~~~~
> Three errors due to "-Werror=unused-value", but 17 each of variations on
These are just side-effects of the actual warning going "missing".
> error: call to ‘__read_overflow’ declared with attribute error:
> detected read beyond size of object (1st parameter)
>
> and
>
> warning: unsafe xyz() usage lacked '__read_overflow' warning
>
> warnings.
The latter is complaining about not seeing the former... O_o
Oh... I found it:
> error: call to ‘__read_overflow’ declared with attribute error:
^ ^
vs:
error: call to '__read_overflow' declared with attribute error:
^ ^
Looks like it's LANG biting me! Ugh.
LANG=en.US.UTF-8 is '
LANG=C is '
LANG=C.UTF-8 is `
Fedora uses C.UTF-8 by default, but my build tooling (and seemingly many
others) are using LANG=en_US.UTF-8 or LANG=C. Specifically, this appears
to be LC_NAME? Fixing now...
--
Kees Cook
next prev parent reply other threads:[~2021-09-05 20:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 3:22 [GIT PULL] overflow updates for v5.15-rc1 Kees Cook
2021-09-04 20:47 ` Linus Torvalds
[not found] ` <45312958-B844-4B4C-9808-8205866675A1@chromium.org>
2021-09-05 17:36 ` Linus Torvalds
2021-09-05 18:21 ` Linus Torvalds
2021-09-05 18:31 ` Kees Cook
2021-09-06 11:43 ` Mark Brown
2021-09-06 17:19 ` Kees Cook
2021-09-05 20:52 ` Kees Cook [this message]
2021-09-06 5:27 ` Stephen Rothwell
2021-09-06 17:12 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109051257.29B29745C0@keescook \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=keithp@keithp.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).