From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 687CAC433F5 for ; Mon, 6 Sep 2021 12:12:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4849060C3E for ; Mon, 6 Sep 2021 12:12:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241931AbhIFMNJ (ORCPT ); Mon, 6 Sep 2021 08:13:09 -0400 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:46061 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241751AbhIFMNI (ORCPT ); Mon, 6 Sep 2021 08:13:08 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=rongwei.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UnRyn5B_1630930321; Received: from localhost.localdomain(mailfrom:rongwei.wang@linux.alibaba.com fp:SMTPD_---0UnRyn5B_1630930321) by smtp.aliyun-inc.com(127.0.0.1); Mon, 06 Sep 2021 20:12:02 +0800 From: Rongwei Wang To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, cfijalkovich@google.com, song@kernel.org, william.kucharski@oracle.com, hughd@google.com Subject: [PATCH 0/2] mm, thp: fix file-backed THP race in collapse_file Date: Mon, 6 Sep 2021 20:11:58 +0800 Message-Id: <20210906121200.57905-1-rongwei.wang@linux.alibaba.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, We found two bugs related to file-backed THP in our cases, recently. The two bugs rough description as following: 1) in truncate_inode_pages_range, subpage(s) of file-backed THP can be revealed by find_get_entry. 2) 'collapse_file' miss the pages which in writeback but no private. This situation will be triggered in XFS when block size is set to PAGESIZE. These two patchs mainly fix the above mentioned bugs, and have been tested in latest branch. Rongwei Wang (2): mm, thp: check page mapping when truncating page cache mm, thp: bail out early in collapse_file for writeback page mm/filemap.c | 7 ++++++- mm/khugepaged.c | 3 ++- mm/truncate.c | 17 ++++++++++++++++- 3 files changed, 24 insertions(+), 3 deletions(-) -- 1.8.3.1