From: Mel Gorman <mgorman@techsingularity.net>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Vlastimil Babka <vbabka@suse.cz>,
Hugh Dickins <hughd@google.com>, Linux-MM <linux-mm@kvack.org>,
Linux-RT-Users <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] mm/vmstat: Protect per cpu variables with preempt disable on RT
Date: Mon, 6 Sep 2021 14:48:20 +0100 [thread overview]
Message-ID: <20210906134820.GA3959@techsingularity.net> (raw)
In-Reply-To: <20210831164546.t7b6ksblzhsmm6jr@linutronix.de>
On Tue, Aug 31, 2021 at 06:45:46PM +0200, Sebastian Andrzej Siewior wrote:
> On 2021-08-05 17:00:19 [+0100], Mel Gorman wrote:
> > mm/vmstat.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 48 insertions(+)
>
> The version in RT also covered the functions
> __count_vm_event()
> __count_vm_events()
>
> in include/linux/vmstat.h. Were they dropped by mistake or on purpose?
>
Sorry for the long delay, this got lost in a mess of mail. It was
dropped on purpose and I tried to explain why in the changelog
This patch differs from the preempt-rt version where
__count_vm_event and __count_vm_events are also protected. The
counters are explicitly "allowed to be to be racy" so there is
no need to protect them from preemption. Only the accurate page
stats that are updated by a read-modify-write need protection. This
patch also differs in that a preempt_[en|dis]able_rt helper is not
used. As vmstat is the only user of the helper, it was suggested
that it be open-coded in vmstat.c instead of risking the helper
being used in unnecessary contexts.
Does that answer your question?
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2021-09-06 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 16:00 [PATCH 0/1 v2] Protect vmstats on PREEMPT_RT Mel Gorman
2021-08-05 16:00 ` [PATCH 1/1] mm/vmstat: Protect per cpu variables with preempt disable on RT Mel Gorman
2021-08-05 23:22 ` Andrew Morton
2021-08-06 7:50 ` Vlastimil Babka
2021-08-06 8:44 ` Mel Gorman
2021-08-06 12:38 ` Vlastimil Babka
2021-08-31 16:45 ` Sebastian Andrzej Siewior
2021-09-02 20:07 ` Andrew Morton
2021-09-06 13:48 ` Mel Gorman [this message]
2021-09-06 14:03 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906134820.GA3959@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).