From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
martin@kaiser.cx, fmdefrancesco@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH v2 35/40] staging: r8188eu: remove empty function rtl8188e_stop_thread()
Date: Mon, 6 Sep 2021 20:53:22 +0200 [thread overview]
Message-ID: <20210906185327.10326-36-straube.linux@gmail.com> (raw)
In-Reply-To: <20210906185327.10326-1-straube.linux@gmail.com>
Remove empty function rtl8188e_stop_thread() and related code.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/hal/hal_intf.c | 7 -------
drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 6 ------
drivers/staging/r8188eu/include/hal_intf.h | 3 ---
drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 -
drivers/staging/r8188eu/os_dep/os_intfs.c | 2 --
5 files changed, 19 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/hal_intf.c b/drivers/staging/r8188eu/hal/hal_intf.c
index 3ea581fb2c7e..4a9820c2b36e 100644
--- a/drivers/staging/r8188eu/hal/hal_intf.c
+++ b/drivers/staging/r8188eu/hal/hal_intf.c
@@ -151,13 +151,6 @@ void rtw_hal_update_ra_mask(struct adapter *adapt, u32 mac_id, u8 rssi_level)
}
}
-/* Start specifical interface thread */
-void rtw_hal_stop_thread(struct adapter *adapt)
-{
- if (adapt->HalFunc.cancel_thread)
- adapt->HalFunc.cancel_thread(adapt);
-}
-
u32 rtw_hal_read_bbreg(struct adapter *adapt, u32 regaddr, u32 bitmask)
{
u32 data = 0;
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
index fc420cbec5de..f87cfa0e404a 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
@@ -1748,10 +1748,6 @@ void rtl8188e_clone_haldata(struct adapter *dst_adapter, struct adapter *src_ada
memcpy(dst_adapter->HalData, src_adapter->HalData, dst_adapter->hal_data_sz);
}
-void rtl8188e_stop_thread(struct adapter *padapter)
-{
-}
-
static void hal_notch_filter_8188e(struct adapter *adapter, bool enable)
{
if (enable) {
@@ -1766,8 +1762,6 @@ void rtl8188e_set_hal_ops(struct hal_ops *pHalFunc)
{
pHalFunc->free_hal_data = &rtl8188e_free_hal_data;
- pHalFunc->cancel_thread = &rtl8188e_stop_thread;
-
pHalFunc->read_bbreg = &rtl8188e_PHY_QueryBBReg;
pHalFunc->write_bbreg = &rtl8188e_PHY_SetBBReg;
pHalFunc->read_rfreg = &rtl8188e_PHY_QueryRFReg;
diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h
index caee83ed962d..fdde4b2b8ec4 100644
--- a/drivers/staging/r8188eu/include/hal_intf.h
+++ b/drivers/staging/r8188eu/include/hal_intf.h
@@ -153,8 +153,6 @@ struct hal_ops {
u32 mac_id, u8 rssi_level);
void (*SetBeaconRelatedRegistersHandler)(struct adapter *padapter);
- void (*cancel_thread)(struct adapter *adapter);
-
s32 (*hal_xmit)(struct adapter *padapter,
struct xmit_frame *pxmitframe);
s32 (*mgnt_xmit)(struct adapter *padapter,
@@ -236,7 +234,6 @@ void rtw_hal_free_recv_priv(struct adapter *padapter);
void rtw_hal_update_ra_mask(struct adapter *padapter, u32 mac_id, u8 level);
void rtw_hal_clone_data(struct adapter *dst_adapt,
struct adapter *src_adapt);
-void rtw_hal_stop_thread(struct adapter *padapter);
void rtw_hal_bcn_related_reg_setting(struct adapter *padapter);
diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
index 5947708594d2..40bc00a9b23b 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
@@ -439,7 +439,6 @@ void rtl8188e_set_hal_ops(struct hal_ops *pHalFunc);
void rtl8188e_read_chip_version(struct adapter *padapter);
void rtl8188e_clone_haldata(struct adapter *dst, struct adapter *src);
-void rtl8188e_stop_thread(struct adapter *padapter);
void rtw_IOL_cmd_tx_pkt_buf_dump(struct adapter *Adapter, int len);
s32 rtl8188e_iol_efuse_patch(struct adapter *padapter);
diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
index c18f6a7237c7..3b277774b39a 100644
--- a/drivers/staging/r8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/r8188eu/os_dep/os_intfs.c
@@ -742,8 +742,6 @@ void rtw_stop_drv_threads(struct adapter *padapter)
up(&padapter->cmdpriv.cmd_queue_sema);
if (padapter->cmdThread)
_rtw_down_sema(&padapter->cmdpriv.terminate_cmdthread_sema);
-
- rtw_hal_stop_thread(padapter);
}
static u8 rtw_init_default_value(struct adapter *padapter)
--
2.33.0
next prev parent reply other threads:[~2021-09-06 18:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 18:52 [PATCH v2 00/40] staging: r8188eu: remove function pointers from struct hal_ops Michael Straube
2021-09-06 18:52 ` [PATCH v2 01/40] staging: r8188eu: remove InitSwLeds from hal_ops Michael Straube
2021-09-06 18:52 ` [PATCH v2 02/40] staging: r8188eu: remove DeInitSwLeds " Michael Straube
2021-09-06 18:52 ` [PATCH v2 03/40] staging: r8188eu: remove dm_init " Michael Straube
2021-09-06 18:52 ` [PATCH v2 04/40] staging: r8188eu: remove dm_deinit " Michael Straube
2021-09-06 18:52 ` [PATCH v2 05/40] staging: r8188eu: remove SetHalODMVarHandler " Michael Straube
2021-09-06 18:52 ` [PATCH v2 06/40] staging: r8188eu: remove empty functions Michael Straube
2021-09-06 18:52 ` [PATCH v2 07/40] staging: r8188eu: remove unused function rtw_interface_ps_func() Michael Straube
2021-09-06 18:52 ` [PATCH v2 08/40] staging: r8188eu: remove interface_ps_func from hal_ops Michael Straube
2021-09-06 18:52 ` [PATCH v2 09/40] staging: r8188eu: remove hal_dm_watchdog " Michael Straube
2021-09-06 18:52 ` [PATCH v2 10/40] staging: r8188eu: remove set_bwmode_handler " Michael Straube
2021-09-06 18:52 ` [PATCH v2 11/40] staging: r8188eu: remove set_channel_handler " Michael Straube
2021-09-06 18:52 ` [PATCH v2 12/40] staging: r8188eu: remove unused enum hal_intf_ps_func Michael Straube
2021-09-06 18:53 ` [PATCH v2 13/40] staging: r8188eu: remove Add_RateATid from hal_ops Michael Straube
2021-09-06 18:53 ` [PATCH v2 14/40] staging: r8188eu: remove hal_power_on " Michael Straube
2021-09-06 18:53 ` [PATCH v2 15/40] staging: r8188eu: remove sreset_init_value " Michael Straube
2021-09-06 18:53 ` [PATCH v2 16/40] staging: r8188eu: remove sreset_reset_value " Michael Straube
2021-09-06 18:53 ` [PATCH v2 17/40] staging: r8188eu: remove silentreset " Michael Straube
2021-09-06 18:53 ` [PATCH v2 18/40] staging: r8188eu: remove sreset_xmit_status_check " Michael Straube
2021-09-06 18:53 ` [PATCH v2 19/40] staging: r8188eu: remove sreset_linked_status_check " Michael Straube
2021-09-06 18:53 ` [PATCH v2 20/40] staging: r8188eu: remove sreset_get_wifi_status " Michael Straube
2021-09-06 18:53 ` [PATCH v2 21/40] staging: r8188eu: remove EfusePowerSwitch " Michael Straube
2021-09-06 18:53 ` [PATCH v2 22/40] staging: r8188eu: rename hal_EfusePowerSwitch_RTL8188E() Michael Straube
2021-09-06 18:53 ` [PATCH v2 23/40] staging: r8188eu: remove wrapper Efuse_PowerSwitch() Michael Straube
2021-09-06 18:53 ` [PATCH v2 24/40] staging: r8188eu: remove ReadEFuse from hal_ops Michael Straube
2021-09-06 18:53 ` [PATCH v2 25/40] staging: r8188eu: remove EFUSEGetEfuseDefinition " Michael Straube
2021-09-06 18:53 ` [PATCH v2 26/40] staging: r8188eu: remove EfuseGetCurrentSize " Michael Straube
2021-09-06 18:53 ` [PATCH v2 27/40] staging: r8188eu: remove empty comments Michael Straube
2021-09-06 18:53 ` [PATCH v2 28/40] staging: r8188eu: remove Efuse_PgPacketRead from hal_ops Michael Straube
2021-09-06 18:53 ` [PATCH v2 29/40] staging: r8188eu: remove Efuse_PgPacketWrite " Michael Straube
2021-09-06 18:53 ` [PATCH v2 30/40] staging: r8188eu: remove Efuse_WordEnableDataWrite " Michael Straube
2021-09-06 18:53 ` [PATCH v2 31/40] staging: r8188eu: remove useless assignment Michael Straube
2021-09-06 18:53 ` [PATCH v2 32/40] staging: r8188eu: remove AntDivBeforeLinkHandler from hal_ops Michael Straube
2021-09-06 18:53 ` [PATCH v2 33/40] staging: r8188eu: remove AntDivCompareHandler " Michael Straube
2021-09-06 18:53 ` [PATCH v2 34/40] staging: r8188eu: remove empty function rtl8188e_start_thread() Michael Straube
2021-09-06 18:53 ` Michael Straube [this message]
2021-09-06 18:53 ` [PATCH v2 36/40] staging: r8188eu: remove hal_notch_filter from hal_ops Michael Straube
2021-09-06 18:53 ` [PATCH v2 37/40] staging: r8188eu: remove free_hal_data " Michael Straube
2021-09-06 18:53 ` [PATCH v2 38/40] staging: r8188eu: remove unused function rtl8188e_clone_haldata() Michael Straube
2021-09-06 18:53 ` [PATCH v2 39/40] staging: r8188eu: remove SetBeaconRelatedRegistersHandler from hal_ops Michael Straube
2021-09-06 18:53 ` [PATCH v2 40/40] staging: r8188eu: remove UpdateHalRAMask8188EUsb " Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906185327.10326-36-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).