* [PATCH] hw_random: ixp4xx: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-07 7:40 Cai Huoqing
2021-09-17 3:20 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2021-09-07 7:40 UTC (permalink / raw)
To: caihuoqing
Cc: Deepak Saxena, Matt Mackall, Herbert Xu, linux-crypto, linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/char/hw_random/ixp4xx-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/ixp4xx-rng.c b/drivers/char/hw_random/ixp4xx-rng.c
index 188854dd16a9..7df5e9f7519d 100644
--- a/drivers/char/hw_random/ixp4xx-rng.c
+++ b/drivers/char/hw_random/ixp4xx-rng.c
@@ -42,13 +42,11 @@ static int ixp4xx_rng_probe(struct platform_device *pdev)
{
void __iomem * rng_base;
struct device *dev = &pdev->dev;
- struct resource *res;
if (!cpu_is_ixp46x()) /* includes IXP455 */
return -ENOSYS;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- rng_base = devm_ioremap_resource(dev, res);
+ rng_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(rng_base))
return PTR_ERR(rng_base);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw_random: ixp4xx: Make use of the helper function devm_platform_ioremap_resource()
2021-09-07 7:40 [PATCH] hw_random: ixp4xx: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-17 3:20 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2021-09-17 3:20 UTC (permalink / raw)
To: Cai Huoqing; +Cc: Deepak Saxena, Matt Mackall, linux-crypto, linux-kernel
On Tue, Sep 07, 2021 at 03:40:41PM +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/char/hw_random/ixp4xx-rng.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-17 3:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 7:40 [PATCH] hw_random: ixp4xx: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-17 3:20 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).