Re: [PATCH] usb: ehci: Simplify platform driver registration

From: kernel test robot <lkp@intel.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Alan Stern <stern@rowland.harvard.edu>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] usb: ehci: Simplify platform driver registration
Date: Tue, 7 Sep 2021 14:37:30 +0800	[thread overview]
Message-ID: <202109071426.u84ujAE1-lkp@intel.com> (raw)
In-Reply-To: <20210907044527.2137211-1-linux@roeck-us.net>

[-- Attachment #1: Type: text/plain, Size: 3331 bytes --]

Hi Guenter,

I love your patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.14 next-20210907]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Guenter-Roeck/usb-ehci-Simplify-platform-driver-registration/20210907-124747
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-randconfig-a011-20210906 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9c476172b93367d2cb88d7d3f4b1b5b456fa6020)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bd9aa6646a29d48171474905fedca85ac7ff6ce5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Guenter-Roeck/usb-ehci-Simplify-platform-driver-registration/20210907-124747
        git checkout bd9aa6646a29d48171474905fedca85ac7ff6ce5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/usb/host/ehci-hcd.c:1340:11: error: implicit declaration of function 'platform_register_drivers' [-Werror,-Wimplicit-function-declaration]
           retval = platform_register_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
                    ^
>> drivers/usb/host/ehci-hcd.c:1357:2: error: implicit declaration of function 'platform_unregister_drivers' [-Werror,-Wimplicit-function-declaration]
           platform_unregister_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
           ^
   drivers/usb/host/ehci-hcd.c:1357:2: note: did you mean 'pci_unregister_driver'?
   include/linux/pci.h:1433:6: note: 'pci_unregister_driver' declared here
   void pci_unregister_driver(struct pci_driver *dev);
        ^
   2 errors generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_SOC_MT6359
   Depends on SOUND && !UML && SND && SND_SOC && MTK_PMIC_WRAP
   Selected by
   - SND_SOC_MT8195_MT6359_RT1019_RT5682 && SOUND && !UML && SND && SND_SOC && I2C && SND_SOC_MT8195

vim +/platform_register_drivers +1340 drivers/usb/host/ehci-hcd.c

  1339	
> 1340		retval = platform_register_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
  1341		if (retval < 0)
  1342			goto clean0;
  1343		return 0;
  1344	
  1345	clean0:
  1346	#ifdef CONFIG_DYNAMIC_DEBUG
  1347		debugfs_remove(ehci_debug_root);
  1348		ehci_debug_root = NULL;
  1349	#endif
  1350		clear_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
  1351		return retval;
  1352	}
  1353	module_init(ehci_hcd_init);
  1354	
  1355	static void __exit ehci_hcd_cleanup(void)
  1356	{
> 1357		platform_unregister_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37346 bytes --]