From: Shawn Guo <shawn.guo@linaro.org>
To: Soeren Moch <smoch@web.de>
Cc: "Kalle Valo" <kvalo@codeaurora.org>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Arend van Spriel" <aspriel@gmail.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Chi-hsien Lin" <chi-hsien.lin@infineon.com>,
"Wright Feng" <wright.feng@infineon.com>,
"Chung-hsien Hsu" <chung-hsien.hsu@infineon.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>
Subject: Re: [BUG] Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback
Date: Wed, 8 Sep 2021 09:00:58 +0800 [thread overview]
Message-ID: <20210908010057.GB25255@dragon> (raw)
In-Reply-To: <cb7ac252-3356-8ef7-fcf9-eb017f5f161f@web.de>
Hi Soeren,
On Tue, Sep 07, 2021 at 09:22:52PM +0200, Soeren Moch wrote:
> On 25.04.21 13:02, Shawn Guo wrote:
> > Instead of aborting country code setup in firmware, use ISO3166 country
> > code and 0 rev as fallback, when country_codes mapping table is not
> > configured. This fallback saves the country_codes table setup for recent
> > brcmfmac chipsets/firmwares, which just use ISO3166 code and require no
> > revision number.
> This patch breaks wireless support on RockPro64. At least the access
> point is not usable, station mode not tested.
>
> brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4359/9 wl0: Mar 6 2017
> 10:16:06 version 9.87.51.7 (r686312) FWID 01-4dcc75d9
>
> Reverting this patch makes the access point show up again with linux-5.14 .
Sorry for breaking your device!
So it sounds like you do not have country_codes configured for your
BCM4359/9 device, while it needs particular `rev` setup for the ccode
you are testing with. It was "working" likely because you have a static
`ccode` and `regrev` setting in nvram file. But roaming to a different
region will mostly get you a broken WiFi support. Is it possible to set
up the country_codes for your device to get it work properly?
Shawn
>
> Regards,
> Soeren
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > ---
> > .../broadcom/brcm80211/brcmfmac/cfg80211.c | 17 +++++++++++------
> > 1 file changed, 11 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> > index f4405d7861b6..6cb09c7c37b6 100644
> > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> > @@ -7442,18 +7442,23 @@ static s32 brcmf_translate_country_code(struct brcmf_pub *drvr, char alpha2[2],
> > s32 found_index;
> > int i;
> >
> > - country_codes = drvr->settings->country_codes;
> > - if (!country_codes) {
> > - brcmf_dbg(TRACE, "No country codes configured for device\n");
> > - return -EINVAL;
> > - }
> > -
> > if ((alpha2[0] == ccreq->country_abbrev[0]) &&
> > (alpha2[1] == ccreq->country_abbrev[1])) {
> > brcmf_dbg(TRACE, "Country code already set\n");
> > return -EAGAIN;
> > }
> >
> > + country_codes = drvr->settings->country_codes;
> > + if (!country_codes) {
> > + brcmf_dbg(TRACE, "No country codes configured for device, using ISO3166 code and 0 rev\n");
> > + memset(ccreq, 0, sizeof(*ccreq));
> > + ccreq->country_abbrev[0] = alpha2[0];
> > + ccreq->country_abbrev[1] = alpha2[1];
> > + ccreq->ccode[0] = alpha2[0];
> > + ccreq->ccode[1] = alpha2[1];
> > + return 0;
> > + }
> > +
> > found_index = -1;
> > for (i = 0; i < country_codes->table_size; i++) {
> > cc = &country_codes->table[i];
>
next prev parent reply other threads:[~2021-09-08 1:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210425110200.3050-1-shawn.guo@linaro.org>
2021-09-07 19:22 ` [BUG] Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback Soeren Moch
2021-09-08 1:00 ` Shawn Guo [this message]
2021-09-08 5:08 ` Soeren Moch
2021-09-09 2:20 ` Shawn Guo
2021-09-09 8:39 ` Soeren Moch
2021-09-12 1:51 ` Shawn Guo
2021-09-21 9:20 ` Kalle Valo
2021-09-26 20:20 ` Soeren Moch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210908010057.GB25255@dragon \
--to=shawn.guo@linaro.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=smoch@web.de \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).