From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E56EC433EF for ; Wed, 8 Sep 2021 15:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CAA46113C for ; Wed, 8 Sep 2021 15:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344816AbhIHPzB (ORCPT ); Wed, 8 Sep 2021 11:55:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:59578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235546AbhIHPzA (ORCPT ); Wed, 8 Sep 2021 11:55:00 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB4156113D; Wed, 8 Sep 2021 15:53:51 +0000 (UTC) Date: Wed, 8 Sep 2021 11:53:50 -0400 From: Steven Rostedt To: Guenter Roeck Cc: Daniel Bristot de Oliveira , Ingo Molnar , linux-kernel@vger.kernel.org, Linus Torvalds , Randy Dunlap Subject: Re: [PATCH] trace/osnoise: Do not use 'main' as variable name Message-ID: <20210908115350.555941ba@oasis.local.home> In-Reply-To: <20210908151407.217052-1-linux@roeck-us.net> References: <20210908151407.217052-1-linux@roeck-us.net> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Sep 2021 08:14:07 -0700 Guenter Roeck wrote: > gcc 11.x may get a hiccup when encountering 'main' as variable name. > > kernel/trace/trace_osnoise.c: In function 'start_kthread': > kernel/trace/trace_osnoise.c:1515:8: error: 'main' is usually a function > > Use a different variable name to silence it. Egad, no. NACK! Double NACK. Linus already NACK'd this. (although it's ironic that he also added -Werror as the default :-/ ) The bug in is in gcc, go send them a patch. THERE IS NO ISSUE WITH HAVING A LOCAL VARIABLE NAMED "main"!!!! This has already been discussed: https://lore.kernel.org/all/CAHk-=whHxeUjaNrWOLb0qx=-nibRZzQomwkw9xMPH_aHCf=BWQ@mail.gmail.com/ For now, the workaround is this patch: https://lore.kernel.org/all/20210813224131.25803-1-rdunlap@infradead.org/ -- Steve > > Signed-off-by: Guenter Roeck > --- > kernel/trace/trace_osnoise.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c > index 65b08b8e5bf8..7a4c73b4fdcf 100644 > --- a/kernel/trace/trace_osnoise.c > +++ b/kernel/trace/trace_osnoise.c > @@ -1512,20 +1512,20 @@ static void stop_per_cpu_kthreads(void) > static int start_kthread(unsigned int cpu) > { > struct task_struct *kthread; > - void *main = osnoise_main; > + void *func = osnoise_main; > char comm[24]; > > #ifdef CONFIG_TIMERLAT_TRACER > if (osnoise_data.timerlat_tracer) { > snprintf(comm, 24, "timerlat/%d", cpu); > - main = timerlat_main; > + func = timerlat_main; > } else { > snprintf(comm, 24, "osnoise/%d", cpu); > } > #else > snprintf(comm, 24, "osnoise/%d", cpu); > #endif > - kthread = kthread_create_on_cpu(main, NULL, cpu, comm); > + kthread = kthread_create_on_cpu(func, NULL, cpu, comm); > > if (IS_ERR(kthread)) { > pr_err(BANNER "could not start sampling thread\n");